Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor readers vii #249

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Refactor readers vii #249

merged 6 commits into from
Jan 9, 2025

Conversation

mschwoer
Copy link
Contributor

separate the file loading and preprocessing

@mschwoer mschwoer marked this pull request as ready for review November 21, 2024 08:45
@mschwoer mschwoer mentioned this pull request Nov 26, 2024
Open
GeorgWa
GeorgWa approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphabase/psm_reader/dia_psm_reader.py Show resolved Hide resolved
alphabase/psm_reader/sage_reader.py Show resolved Hide resolved
Base automatically changed from refactor_readers_VI to development January 9, 2025 08:42
@mschwoer mschwoer merged commit 3517459 into development Jan 9, 2025
2 checks passed
@mschwoer mschwoer deleted the refactor_readers_VII branch January 9, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa GeorgWa approved these changes

@jalew188 jalew188 Awaiting requested review from jalew188

@lucas-diedrich lucas-diedrich Awaiting requested review from lucas-diedrich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @GeorgWa