Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alphadia reader #254

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Add alphadia reader #254

merged 7 commits into from
Jan 9, 2025

Conversation

mschwoer
Copy link
Contributor

add AlphaDIA reader

@mschwoer mschwoer requested a review from GeorgWa November 22, 2024 15:18
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me



def register_readers() -> None:
"""Register MaxQuant reader."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Nit) Register Alphadia Reader

@mschwoer mschwoer force-pushed the add_alphadia_reader branch 2 times, most recently from d2ad691 to 673660b Compare November 25, 2024 15:58
@mschwoer mschwoer force-pushed the add_alphadia_reader branch from 3e745b3 to 239e2ef Compare November 26, 2024 09:35
@mschwoer mschwoer marked this pull request as ready for review November 26, 2024 10:37
Copy link
Collaborator

@jalew188 jalew188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally we have alphadia reader

Base automatically changed from refactor_readers_XI to development January 9, 2025 16:27
@mschwoer mschwoer merged commit 458459d into development Jan 9, 2025
3 checks passed
@mschwoer mschwoer deleted the add_alphadia_reader branch January 9, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants