Refactor flat to dense conversion #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwoer
reviewed
Jan 10, 2025
mschwoer
reviewed
Jan 10, 2025
GeorgWa
changed the base branch from
refactor-fragments
to
fragment-constant-II
mschwoer
reviewed
Jan 16, 2025
| row_indices = row_indices[match_mask] | ||
|
|
||
| # create a dictionary with the mz matrix and the flat columns | ||
| df_collection = {"mz": fragment_mz_df} |
There was a problem hiding this comment.
There was a problem hiding this comment.
implemented here:
#277
mschwoer
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make the conversion of flat libraries comaptible with arbitrary charged fragment types. This implementation follows the same logic as the old one but should be more modular and robust.
I will remove the old implementation in a separate PR