Refactor config #411
Open
Refactor config #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwoer
added
the
test:e2e
mschwoer
force-pushed
the
add_unit_test_for_config
branch
from
d91f9be to
42b4798
Compare
This reverts commit f7592c5.
mschwoer
force-pushed
the
refactor_config
branch
from
5ac3a8c to
9850c73
Compare
install mono in CI
GeorgWa
approved these changes
Dec 27, 2024
| @@ -26,7 +31,7 @@ library_prediction: | |||
| variable_modifications: 'Oxidation@M;Acetyl@Protein_N-term' | |||
| max_var_mod_num: 2 | |||
| missed_cleavages: 1 | |||
| precursor_len: | |||
| precursor_len: # TODO: make this min/max ? | |||
There was a problem hiding this comment.
The way how the gui interacts with the config makes it easier if this is a treated like a fixed length tuple.
| do_print : bool, optional | ||
| Whether to print the modified config. Default is False. | ||
| """ | ||
|
|
There was a problem hiding this comment.
Can you add a sentence about the strategy of using a tracking config
| """ | ||
| Recursively update target_dict in-place with values from update_dict, following specific rules for different types. | ||
|
|
||
| For each value that gets updated, the corresponding value in tracking_dict is updated with experiment_name. |
There was a problem hiding this comment.
The variable name experiment_name was a bit of a misstranslation which we kept for too long. Let's rename it here.
|
|
||
| For each value that gets updated, the corresponding value in tracking_dict is updated with experiment_name. | ||
|
|
||
| Args: |
There was a problem hiding this comment.
(nit) numpy style docstrings
| """ | ||
| for key, update_value in update_config.items(): | ||
| if key not in target_config: | ||
| raise ValueError(f"Key not found in target_config: '{key}'") |
There was a problem hiding this comment.
Should we make this more explicit?
Something like: Updating configs does not allow defining new keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the config class:
tracking_configvariable)