Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New backend for results display and interface for volcano plot #390

Merged
merged 32 commits into from
Jan 20, 2025
Merged

New backend for results display and interface for volcano plot #390

merged 32 commits into from
Jan 20, 2025

Conversation

JuliaS92
Copy link
Collaborator

@JuliaS92 JuliaS92 commented Jan 8, 2025 •
edited
Loading

Previously the analysis immediately returned a plot that was then displayed. I introduced a ResultComponent, which stores the dataframe and creates the plot, based on widgets for customizing it, including the significance cutoffs.

This is now implemented on all pages based on a new AnalysisComponent for DEA on two groups.

  • Tests (could be expanded)
  • Documentation
  • Download options
  • Integration into results page
  • Integration with LLM page
  • Parameterize FDR control

@JuliaS92 JuliaS92 marked this pull request as ready for review January 9, 2025 10:47
@JuliaS92 JuliaS92 requested a review from vbrennsteiner January 9, 2025 10:51
mschwoer
mschwoer approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

alphastats/gui/utils/ui_helper.py Outdated Show resolved Hide resolved
alphastats/gui/utils/analysis_helper.py Outdated Show resolved Hide resolved
alphastats/gui/utils/result.py Outdated Show resolved Hide resolved
alphastats/gui/utils/result.py Outdated Show resolved Hide resolved
alphastats/gui/utils/result.py Outdated Show resolved Hide resolved
alphastats/gui/utils/result.py Outdated Show resolved Hide resolved
alphastats/gui/utils/result.py Outdated Show resolved Hide resolved
alphastats/pl/volcano.py Outdated Show resolved Hide resolved
alphastats/pl/volcano.py Show resolved Hide resolved
alphastats/tl/differential_expression_analysis.py Show resolved Hide resolved
boopthesnoot
boopthesnoot approved these changes Jan 20, 2025
View reviewed changes
alphastats/gui/pages/05_Analysis.py Show resolved Hide resolved
alphastats/gui/utils/result.py Outdated Show resolved Hide resolved
@JuliaS92 JuliaS92 merged commit 3c5ac58 into development Jan 20, 2025
5 checks passed
@JuliaS92 JuliaS92 deleted the volcanoplot branch January 20, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwoer mschwoer mschwoer approved these changes

@boopthesnoot boopthesnoot boopthesnoot approved these changes

@vbrennsteiner vbrennsteiner Awaiting requested review from vbrennsteiner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuliaS92 @boopthesnoot @mschwoer