MDEV-35207 ignored error at binlogging by CREATE-TABLE-SELECT leads to assert + MDEV-35499 + MDEV-35502 #3664
Conversation
…o assert
MDEV-35499 Errored-out CREATE-or-REPLACE-SELECT does not DROP table in binlog
MDEV-35502 Failed at ROW-format binlogging CREATE-TABLE-SELECT should
not cause Incident event
ha_commit_one_phase() path to commit CREATE-TABLE-SELECT features
a possibility of a failure within binlog_commit() before to flush
the transaction's caches to binlog.
In such case the "autocommit" statement is supposed to roll back.
However CREATE-TABLE-SELECT handler skipped checking of an error
presence so execution proceeded to either implicit commit or send OK
to hit an assert in ether branch.
The fixes install the checking in select_create::send_eof().
This commit also covers CREATE-or-REPLACE-SELECT that additionally had
a "personal" issue to miss DROP TABLE logging into the binary log, MDEV-35499.
See select_create::abort_result_set().
The current commit also corrects from unnecessary Incident event
logging when it's C-T-S that suffers from a binloging issue, MDEV-35502.
The Incident was actually only harmful in this case.
|
|
|
@andrelkin You probably want to rebase your branch on top of most recent |
|
Thanks, @cvicentiu ! (And sorry to force you replicating your alarms). |
Description
TODO: fill description here
Release Notes
TODO: What should the release notes say about this change?
Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing.
How can this PR be tested?
TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended.
Consult the documentation on "Writing good test cases".
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check