Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second request merge of BfG spectra to MassBank dev #246

Closed
wants to merge 8 commits into from

Conversation

ksjewell
Copy link

I made the changes requested in PR "Request merge of BfG Spectra to MassBank dev #245".
All the files were updated.

@ksjewell
Copy link
Author

ksjewell commented Oct 25, 2023

I see the validation error. I'll correct it and export again.

@ksjewell ksjewell closed this Oct 25, 2023
@meier-rene
Copy link
Collaborator

I had a look at it. There are two issues:

  • AC$MASS_SPECTROMETRY: MS_TYPE CID should be AC$MASS_SPECTROMETRY: MS_TYPE MS2
  • ionisation should look like this AC$MASS_SPECTROMETRY: FRAGMENTATION_MODE CID
  • there is an empty line at the end and the validator will complain.

@ksjewell
Copy link
Author

I made the first two corrections but the last one has to do with
export(MsBackendMassbank(), sps, file = glue("{saveDir}/{sps$accession}.txt"))
the Spectra function, correct?

@meier-rene
Copy link
Collaborator

You are probably right. Then it needs to be fixed there. please dont put too much effort in this on. I can easily do that after the export.

@ksjewell
Copy link
Author

No problem, I'll just fix it after export with sed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants