Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow for single recipe case aggregation by lead time #1086

Merged
merged 12 commits into from
Feb 3, 2025

Conversation

daflack
Copy link
Contributor

@daflack daflack commented Jan 28, 2025

Update workflow for single recipe case aggregation by lead time

Fixes #1031

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@daflack daflack marked this pull request as draft January 28, 2025 11:50
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Coverage

@daflack daflack force-pushed the case_aggregation_lead_time_workflow branch from 95f5220 to a648a7e Compare January 28, 2025 14:17
@daflack
Copy link
Contributor Author

daflack commented Jan 28, 2025

Recipes to be aggregated over as part of this PR are all generic (except QQ plots) and the spatial difference plots. Other aggregation recipes can be added at a later date.

@daflack
Copy link
Contributor Author

daflack commented Jan 29, 2025

Note to reviewers: out of the workflow changes, this one needs to be reviewed first. Note it will be merged (and rebased) after PR #540 completed.

@daflack daflack marked this pull request as ready for review January 29, 2025 13:35
@daflack daflack marked this pull request as draft January 29, 2025 14:35
@daflack
Copy link
Contributor Author

daflack commented Jan 29, 2025

Need to work out housekeeping before review.

@daflack daflack force-pushed the case_aggregation_lead_time_workflow branch from a9f4c98 to 95ea2dc Compare January 30, 2025 10:27
@daflack daflack force-pushed the case_aggregation_lead_time_workflow branch from bc5c4fe to a1d488b Compare January 31, 2025 09:20
@daflack daflack marked this pull request as ready for review January 31, 2025 10:53
@daflack
Copy link
Contributor Author

daflack commented Jan 31, 2025

@jwarner8, and @Sylviabohnenstengel: Review this one first but test in PR #1102

@daflack daflack merged commit 28b1257 into main Feb 3, 2025
8 checks passed
@daflack daflack deleted the case_aggregation_lead_time_workflow branch February 3, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow changes to collapse by lead time
3 participants