Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow to allow case aggregation by hour of day #1101

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

daflack
Copy link
Contributor

@daflack daflack commented Jan 29, 2025

Adds recipe and includes files, updates rose-meta.conf in diagnostics for hour of day aggregation.

Fixes #1032

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@daflack daflack self-assigned this Jan 29, 2025
@daflack daflack marked this pull request as draft January 29, 2025 14:24
@daflack
Copy link
Contributor Author

daflack commented Jan 29, 2025

Need to work out histogram aggregation - possibly will require a new operator to allow it to work.

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Coverage

@daflack daflack force-pushed the case_aggregation_hour_workflow branch 3 times, most recently from 4f0c11f to b137f44 Compare January 30, 2025 13:24
@daflack daflack force-pushed the case_aggregation_hour_workflow branch from 8f8b754 to 2d9d2b2 Compare January 31, 2025 09:29
@daflack
Copy link
Contributor Author

daflack commented Jan 31, 2025

Note: this PR has been rebased with respect to PR #1086 to enable testing.

@daflack
Copy link
Contributor Author

daflack commented Jan 31, 2025

Need to work out histogram aggregation - possibly will require a new operator to allow it to work.

Histogram for full deterministic model based on realization. We have decided to not implement aggregation by hour for histograms at the present time as it does not feel needed or sensible.

@daflack
Copy link
Contributor Author

daflack commented Jan 31, 2025

@jwarner8, @Sylviabohnenstengel: Review this one second, and test in PR #1102

@daflack daflack marked this pull request as ready for review January 31, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow changes to collapse by hour
1 participant