-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates workflow for aggregation by validity time #1102
Open
daflack
wants to merge
21
commits into
main
Choose a base branch
from
case_aggregation_validity_time_workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As with PR #1101 need to work out histograms as it may require a new operator to successfully aggregate across cases. |
daflack
force-pushed
the
case_aggregation_validity_time_workflow
branch
from
January 30, 2025 10:47
360f6ce
to
ca99bc4
Compare
… for hour of day aggregation. Fixes #1032
This PR has been rebased onto PR #1101 to allow full testing going forward. |
…nf for validity time aggregation. Fixes #1033
daflack
force-pushed
the
case_aggregation_validity_time_workflow
branch
from
January 31, 2025 10:01
ca99bc4
to
b364fee
Compare
7 tasks
@jwarner8, @Sylviabohnenstengel: Review this one last and test in this one (for all three aggregation workflow PRs). |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds recipes and includes files, and updates diagnostics/rose-meta.conf for validity time aggregation.
Fixes #1033
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.