Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates workflow for aggregation by validity time #1102

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Updates workflow for aggregation by validity time #1102

merged 1 commit into from
Feb 3, 2025

Conversation

daflack
Copy link
Contributor

@daflack daflack commented Jan 29, 2025 •
edited
Loading

Adds recipes and includes files, and updates diagnostics/rose-meta.conf for validity time aggregation.

Fixes #1033

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@daflack daflack self-assigned this Jan 29, 2025
@daflack daflack marked this pull request as draft January 29, 2025 14:55
@daflack
Copy link
Contributor Author

daflack commented Jan 29, 2025

As with PR #1101 need to work out histograms as it may require a new operator to successfully aggregate across cases.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025 •
edited
Loading

Coverage

@daflack daflack force-pushed the case_aggregation_validity_time_workflow branch from 360f6ce to ca99bc4 Compare January 30, 2025 10:47
@daflack
Copy link
Contributor Author

daflack commented Jan 31, 2025

As with PR #1101 need to work out histograms as it may require a new operator to successfully aggregate across cases.

As with PR #1101 we are not proceeding with this idea at the moment.

@daflack
Copy link
Contributor Author

daflack commented Jan 31, 2025

This PR has been rebased onto PR #1101 to allow full testing going forward.

@daflack daflack force-pushed the case_aggregation_validity_time_workflow branch from ca99bc4 to b364fee Compare January 31, 2025 10:01
@daflack daflack mentioned this pull request Jan 31, 2025
Merged
7 tasks
@daflack daflack marked this pull request as ready for review January 31, 2025 10:55
@daflack
Copy link
Contributor Author

daflack commented Jan 31, 2025

@jwarner8, @Sylviabohnenstengel: Review this one last and test in this one (for all three aggregation workflow PRs).

@daflack daflack mentioned this pull request Jan 31, 2025
Merged
7 tasks
@daflack daflack force-pushed the case_aggregation_validity_time_workflow branch from 21ca125 to 3393cd3 Compare February 3, 2025 11:35
jwarner8
jwarner8 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@jwarner8 jwarner8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge.

@daflack daflack merged commit 7eb3815 into main Feb 3, 2025
8 checks passed
@daflack daflack deleted the case_aggregation_validity_time_workflow branch February 3, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwarner8 jwarner8 jwarner8 approved these changes

@Sylviabohnenstengel Sylviabohnenstengel Awaiting requested review from Sylviabohnenstengel

@jfrost-mo jfrost-mo Awaiting requested review from jfrost-mo

Assignees

@daflack daflack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflow changes to allow collapsing by validity time
2 participants
@daflack @jwarner8