Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initial State configuration in tests with PseudoModel configuration #73

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

tom-j-h
Copy link
Contributor

@tom-j-h tom-j-h commented Jan 25, 2024

Description

A coordinate PR to ensure orca-jedi tests pass if this oops PR is merged. Leaving in draft for now since the oops one is.

Issue(s) addressed

None.

Dependencies

https://github.com/JCSDA-internal/oops/pull/2522 would bring about an error in a test when merged. If this change is merged before the OOPS PR then we should be OK.
http://fcm1/projects/utils/ticket/641 must be merged before the OOPS2522 PR.

Impact

None.

Checklist

  • I have updated the unit tests to cover the change
  • New functions are documented briefly via Doxygen comments in the code
  • I have linted my code using cpplint
  • I have run the unit tests
  • I have run mo-bundle to check integration with the rest of JEDI and run the unit tests under all environments

@tom-j-h tom-j-h requested a review from twsearle January 25, 2024 09:28
@tom-j-h tom-j-h self-assigned this Jan 25, 2024
@twsearle
Copy link
Collaborator

There is an associated sith ocean obs processing apps change for this that would have to be coordinated with this change too.

@twsearle
Copy link
Collaborator

@tom-8822 Do you have a link to a mo-bundle build (containing this and the parent change) so that I can test this change against sith? We would need to coordinate the change with sith when it comes down to it, as our operational configs currently have this issue.

@twsearle
Copy link
Collaborator

twsearle commented Jan 25, 2024

The below all look OK to me, however be aware that we have had an anomalous test failure that started appearing overnight for oceansound_multi that is nothing to do with this change.

Testing

Copy link
Collaborator

@twsearle twsearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@twsearle
Copy link
Collaborator

twsearle commented Jan 29, 2024

I think we ought to be able to merge this change independently of the other changes? It is just a test change after all, so as long as the tests are passing on the current develop, I don't see why we can't merge it. I will also double check the ocean apps change is compatible with develop today.

Take it out of draft if you agree @tom-8822

@tom-j-h tom-j-h marked this pull request as ready for review January 29, 2024 10:59
@twsearle twsearle merged commit 57895fb into develop Feb 29, 2024
@twsearle twsearle deleted the feature/enhance_pseudomodel branch August 1, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants