-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added suggestions apps for various categories #29
base: master
Are you sure you want to change the base?
Conversation
Here are my observations:
|
Suggestion need some basic investigations for quality based on their usability apps
Official criteria & contribution guidelines mentioned in README page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed 15 out of 20 files. There are many issues with each suggestion. Please read and address my comments and mark them as resolved why done.
"id": "com.simplemobiletools.clock", | ||
"label": "Simple Clock", | ||
"source": "fg", | ||
"reason": "Combination of a beautiful clock widget, alarm clock, stopwatch, timer", | ||
"repo": "https://github.com/SimpleMobileTools/Simple-Clock" | ||
}, | ||
{ | ||
"id": "com.bnyro.clock", | ||
"label": "Clock You", | ||
"source": "f", | ||
"reason": "Clock and alarms app featuring awesome widgets using Material You", | ||
"repo": "https://github.com/Bnyro/ClockYou" | ||
}, | ||
{ | ||
"id": "com.best.deskclock", | ||
"label": "New Clock", | ||
"source": "f", | ||
"reason": "New Clock is an updated version of the AOSP desk clock, including alarms, clock, timer and stopwatch", | ||
"repo": "https://github.com/qw123wh/new-clock-fdroid" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Require reviews in order to keep only one out of the three. @shuvashish76: Any thoughts?
"id": "com.callrecorder.android", | ||
"label": "Call recorder for Android", | ||
"source": "f", | ||
"reason": "Should work with devices running Android 4.1 (Jelly Bean) and above", | ||
"repo": "https://github.com/riul88/call-recorder-for-android" | ||
}, | ||
{ | ||
"id": "com.github.axet.callrecorder", | ||
"label": "Call Recorder", | ||
"source": "f", | ||
"reason": "Call Recorder with custom recording folder", | ||
"repo": "https://gitlab.com/axet/android-call-recorder" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Require reviews.
{ | ||
"id": "com.simplemobiletools.calendar.pro", | ||
"label": "Simple Calendar Pro", | ||
"source": "fg", | ||
"repo": "https://github.com/SimpleMobileTools/Simple-Calendar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires a review to keep only one out of the two. @shuvashish76: Opinions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Etar supports multiple offline calendars though you don't get as frequent updates as SCP. SCP paid on playstore vs Etar free. Both project active & stable enough for daily use. SCP is their 2nd popular (based on GH stars) app from SMT, so I know a lots of users use it. Need to use it for longer time for proper review. Give us your review @DodoLeDev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comparison table
Feature | SCP | Etar |
---|---|---|
Material Design 3 | ✅ | ❌ |
Add calendar events | ✅ (events and tasks) | ✅ |
CalDav sync | ✅ (opt-out) | ✅ (opt-in) |
Widgets | ✅ | ✅ (only one widget) |
Offline calendars | ✅ (via event types) | ✅ |
Custom day for starting a week | ❌ (only western) | ✅ (global) |
Automatic backups | ✅ | ❌ |
Print calendar | ✅ | ❌ |
Subscription | Free on F-Droid and premium on Play Store | Free |
Size (on F-Droid) | 9.4 MB | 6.2 MB |
Updates | Frequent updates | Less updates |
Maintainability | Backed by Simple Mobile Tools | Backed by Etar and Lineage OS |
SCP gains more points than Etar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/Etar-Group/Etar-Calendar#technical-explanation
Etar calendars are visible to other apps e.g Tasks, no such feature for SCP. SCP events visible to that app only.
SCP gains more points than Etar.
Agreed 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Etar calendars are visible to other apps e.g Tasks, no such feature for SCP. SCP events visible to that app only.
This wasn't considered because this is not something the app should do. It should be managed by a separate calendar provider (e.g. DecSync). Calendar, contacts, etc. in Android is divided into providers and clients for giving users the freedom to choose their favourite clients, and ideally, these clients should never be installed in the system partition (should be installed as user apps during initial setup). There was such a minimal OS called Magma Moonshine (only 4/5 launcher apps) which, unfortunately, was discontinued due to lack of time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So... Should we keep both apps, or remove Etar from the list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So... Should we keep both apps, or remove Etar from the list?
I think Etar should be removed in favour of SCP. Etar has some good features but it's still less appealing than SCP in terms of features that a typical user's looking for.
Hello! Thanks to your comments, I now better understand what are the selection criterias. And I agree with most of your opinions about apps usability and interface preferences. I just thought that the goal was to fill the list with reviewed alteratives, but I was wrong! I will adjust the content of my pull request based on your code reviews and I will add some apps review to support my choices. |
Some issues have been fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some more reviews.
{ | ||
"id": "net.typeblog.shelter", | ||
"label": "Shelter", | ||
"source": "f", | ||
"reason": "Isolate and run multiple instances of apps using Work Profiles", | ||
"repo": "https://gitea.angry.im/PeterCxy/Shelter" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shelter might actually be better than Insular in terms of features e.g. Shelter also freezes the applications in addition to only disabling the work profile.
"repo": "https://github.com/belelaritra/Neumorphic_Calculator" | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think yetCalc is the best among the candidates. But I'm yet to find a calculator capable of replacing my favourite Calculator++ (I wish somebody will continue the project).
@@ -5,6 +5,34 @@ | |||
"repo": "https://github.com/GrapheneOS/Vanadium", | |||
"reason": "GrapheneOS only" | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firefox cannot be added. We've already added a privacy-friendly alternative called “Mull” (by Divest OS).
"reason": "The browser made by Mozilla, developed with user in mind.\nUses their homemade browser engine: GeckoView, and has a native support for extensions.\nContains telemetry bits that can be disabled in settings" | ||
}, | ||
{ | ||
"id": "org.mozilla.fennec_fdroid", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot be added because we've added Mull which is better than Fennec.
"reason": "The Firefox you know, but with proprietary bits and telemetry removed" | ||
}, | ||
{ | ||
"id": "com.duckduckgo.mobile.android", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DDG browser is as bad as their search engine which is basically Bing (and this is basically a WebView).
"reason": "The browser developed by the team that made the DuckDuckGo search engine.\nOffers off-browser features like Email and App tracking protections." | ||
}, | ||
{ | ||
"id": "com.brave.browser", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A better alternatively, Cromite is already added which is better than Brave as it does not have all the Brave telemetry services and advertisements.
@@ -4,5 +4,24 @@ | |||
"label": "Binary Eye", | |||
"source": "fg", | |||
"repo": "https://github.com/markusfisch/BinaryEye" | |||
}, | |||
{ | |||
"id": "com.example.barcodescanner", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks abandoned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abandoned, still connects to Sentry. Upstream PR for that still open & no response from the Owner, which is why F-Droid team fixed it from their side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The app doesn't offer anything better than the other two candidates anyway.
"repo": "https://gitlab.com/Atharok/BarcodeScanner" | ||
}, | ||
{ | ||
"id": "com.google.zxing.client.android", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demo app. Google itself discouraged using it.
"repo": "https://github.com/wewewe718/QrAndBarcodeScanner" | ||
}, | ||
{ | ||
"id": "com.atharok.barcodescanner", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks modern with reasonable size. @shuvashish76: Opinions? If everything is right, we can replace Binary Eye with it. The UI/UX of Binary Eye hasn't been improved in the past few years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only issue I have with this app is that the Internet features are enabled by default (ie. “Query remote API automatically” is enabled by default) which shouldn't be for any reason. Let me explain a bit in case you haven't actually tried the app:
The app has “Open Food Facts” API enabled by default. It's not like that people only scans for food-related barcode. In a super shop, you can scan barcodes related to food, beauty, music — anything. So, it's not ideal to have it enabled anyway. Besides, after scanning the barcode, there's already an option to fetch results using one of the APIs. So, I don't see why this option should be enabled or query automatically by default. If it's intended to be one of the primary or highlighted features, it should be highlighted/featured during the first run (and prompt user to enable it) instead of enabling it by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. There are a few other minor issues:
- Backup allowed but it didn't specify the contents to back up
- No network-security-config present in the manifest (possibly with PKP)
- Non-exported/private activities aren't marked as so
Hello Team, regards nice work in these repository, Just overview https://github.com/Psyhackological/AAA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Root
- AccA (inactive) : IMO probably the best manager. Everything works as expected, doesn't need frequent updates. Feature complete? Front-end of acc & djs which are being activity developed.
- BCL : In maintenance mode, works as expected. Muntashir knows which one is better for general users as he is the maintainer of it.
- Battery Tool : Save battery by stopping apps that are running in the background. I don't think this should be the function of a Battery manager category app especially with root access.
No root
We don't have many choice when it comes to battery managers without root for obvious reasons.
- Batterybot Pro (inactive) : shows temperature, voltage.., conditional alarms, notifications, battery state logs, estimate approx. time remaining etc features. It has lot of useful features for non-rooted device but it's not truly a battery manager.
- SaveTuner : This is probably best for non-rooted devices as it works with ADB permission. I'm not sure what it does with "Firewall" feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACC is known to cause hardware (battery) issues in some cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest BCL for root mode. Battery Tool is like Greenify but not really that effective.
I've used BatteryBot Pro. Good for statistics, but as you said, it doesn't really manage battery. I've never used SaveTuner, so I'm not sure how it works. I'll look into this.
@DodoLeDev: Any updates? You've still got 17 unresolved conversations. |
Oops, sorry for being inactive for so long, but I'm currently focusing on my studies and I forgot about this thing... I'll try to share some updates on the next days |
Hi!
Because the concept of this project is simply genius, I just couldn't resist contributing! 😋
Here is the PR of some of the alt apps that could be used to increase users' freedom and privacy!