Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added suggestions apps for various categories #29
base: master
Are you sure you want to change the base?
Added suggestions apps for various categories #29
Changes from 7 commits
b9f7d80
9ec9b96
86dd21b
a8dc09e
0a5ec08
324758a
c0a17e1
0ec1ad5
8b98787
f33724e
0c0b800
fea78ae
98f8494
e72576e
f5f06e8
47c70ee
a9f98f5
ced5428
f4150b9
205ca1b
172128a
d0fe6f9
7fc175c
1a7bc0d
4bd5c36
63eda44
68c3702
9398035
678fb67
6c5d1c5
15be9b4
b90cf6a
e2e13aa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks abandoned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abandoned, still connects to Sentry. Upstream PR for that still open & no response from the Owner, which is why F-Droid team fixed it from their side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The app doesn't offer anything better than the other two candidates anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks modern with reasonable size. @shuvashish76: Opinions? If everything is right, we can replace Binary Eye with it. The UI/UX of Binary Eye hasn't been improved in the past few years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only issue I have with this app is that the Internet features are enabled by default (ie. “Query remote API automatically” is enabled by default) which shouldn't be for any reason. Let me explain a bit in case you haven't actually tried the app:
The app has “Open Food Facts” API enabled by default. It's not like that people only scans for food-related barcode. In a super shop, you can scan barcodes related to food, beauty, music — anything. So, it's not ideal to have it enabled anyway. Besides, after scanning the barcode, there's already an option to fetch results using one of the APIs. So, I don't see why this option should be enabled or query automatically by default. If it's intended to be one of the primary or highlighted features, it should be highlighted/featured during the first run (and prompt user to enable it) instead of enabling it by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. There are a few other minor issues:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demo app. Google itself discouraged using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Root
No root
We don't have many choice when it comes to battery managers without root for obvious reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACC is known to cause hardware (battery) issues in some cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest BCL for root mode. Battery Tool is like Greenify but not really that effective.
I've used BatteryBot Pro. Good for statistics, but as you said, it doesn't really manage battery. I've never used SaveTuner, so I'm not sure how it works. I'll look into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firefox cannot be added. We've already added a privacy-friendly alternative called “Mull” (by Divest OS).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot be added because we've added Mull which is better than Fennec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DDG browser is as bad as their search engine which is basically Bing (and this is basically a WebView).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A better alternatively, Cromite is already added which is better than Brave as it does not have all the Brave telemetry services and advertisements.