Add Constraint Compile Icon #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrrGit
had a problem deploying
to
test-workflow
GitHub Actions
Failure
goetzrrGit
had a problem deploying
to
test-workflow
GitHub Actions
Failure
goetzrrGit
had a problem deploying
to
test-workflow
GitHub Actions
Failure
goetzrrGit
had a problem deploying
to
test-workflow
GitHub Actions
Failure
goetzrrGit
force-pushed
the
constraint_compile_error_icon
branch
from
133b09c to
8b9a365
Compare
goetzrrGit
had a problem deploying
to
test-workflow
GitHub Actions
Failure
goetzrrGit
force-pushed
the
constraint_compile_error_icon
branch
from
8b9a365 to
85cf7f6
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
|
Not sure why this was closed |
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
goetzrrGit
force-pushed
the
constraint_compile_error_icon
branch
from
85cf7f6 to
89bc3c7
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
goetzrrGit
force-pushed
the
constraint_compile_error_icon
branch
from
89bc3c7 to
4d2cebb
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
|
I'd like to check on the status of this PR. Is it accurate to say that until this PR is merged, the constraint checking feature is unavailable? |
jeffpamer
approved these changes
Dec 8, 2023
We will need this to filter out or 3 types of constraints.
goetzrrGit
force-pushed
the
constraint_compile_error_icon
branch
from
4d2cebb to
f5212eb
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Add constraintID to the response. We will need this to filter out or 3 types of constraints. * Tweak how we store the constraint response data * Use the constraintResponseMap now. * Add warning icon for compile error * Updated code to use because constraintResults have been changed
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Add constraintID to the response. We will need this to filter out or 3 types of constraints. * Tweak how we store the constraint response data * Use the constraintResponseMap now. * Add warning icon for compile error * Updated code to use because constraintResults have been changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #994
I made adjustments to the code because we are now receiving the constraintResponse as an array of responses, each indicating whether a constraint has a compile error, runs with violations, or runs without violations. I've also added an icon in the UI to visually represent when a constraint has a compile error.
You will need the backend from this PR NASA-AMMOS/aerie#1249