Include Pending Events in Event Log #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mythicaeda
force-pushed
the
feat/pending-hasura-events
branch
from
138e89c to
12b53a4
Compare
Mythicaeda
force-pushed
the
feat/pending-hasura-events
branch
from
12b53a4 to
b88a02c
Compare
Mythicaeda
force-pushed
the
feat/pending-hasura-events
branch
from
b88a02c to
e204c1a
Compare
Mythicaeda
force-pushed
the
feat/pending-hasura-events
branch
from
e204c1a to
5b79f79
Compare
Mythicaeda
force-pushed
the
feat/pending-hasura-events
branch
from
fce3d8b to
49cd32a
Compare
Mythicaeda
force-pushed
the
feat/pending-hasura-events
branch
from
49cd32a to
940bfaf
Compare
skovati
approved these changes
Jun 25, 2024
Also, since Javalin uses "Title" instead of "Message", attempt to fallback to the error's "title" if there is no message
…updated - `enable_manual` is set to `true` so the Gateway may invoke them - `jar_id` is included, as if the underlying Jar is updated, the model has fundamentally changed and must be re-extracted Fix missiion_model.yaml
- Remove unthrown exception from `getActivityTypes`
Mythicaeda
force-pushed
the
feat/pending-hasura-events
branch
from
940bfaf to
899da1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two changes have been made to support NASA-AMMOS/aerie-ui#1326:
left joinfromhdb_catalog.event_logto the invocation logs instead of the defaultinner join. The return of the function has also been tweaked to include apendingstatus column to easily identify these rows. An event ispendingif it has not been invoked (identified by the invocation log's primary key beingNULL).jar_idis updated. Additionally, then can now be manually triggered via either the Hasura Console or the Hasura Metadata API (the latter of which is used by the Gateway in this PR)Verification
E2E tests have been updated to fetch and check the new
pendingcolumn.Documentation
No docs need to be updated.
Future work