-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate and replace thrust::identity #3649
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bernhardmgruber
commented
Feb 3, 2025
•
edited
Loading
edited
- Merge before: Fix transform_iterator<identity> and drop result_of_adaptable_function #3652
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
miscco
approved these changes
Feb 3, 2025
e379917
to
57761b7
Compare
/ok to test |
ae36312
to
a2bf039
Compare
/ok to test |
a2bf039
to
a2d33f0
Compare
9fd8a2e
to
89ba2df
Compare
0162945
to
1bfc5fd
Compare
🟩 CI finished in 1h 54m: Pass: 100%/151 | Total: 3d 14h | Avg: 34m 21s | Max: 1h 22m | Hits: 373%/24193
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 151)
# | Runner |
---|---|
108 | linux-amd64-cpu16 |
15 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
8 | linux-amd64-gpu-rtx2080-latest-1 |
6 | linux-amd64-gpu-rtxa6000-latest-1 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
1 | linux-amd64-gpu-h100-latest-1 |
bernhardmgruber
added a commit
to bernhardmgruber/cccl
that referenced
this pull request
Feb 5, 2025
Co-authored-by: Michael Schellenberger Costa <[email protected]>
bernhardmgruber
added a commit
that referenced
this pull request
Feb 5, 2025
…te thrust::identity (#3649) (#3693) * Fix transform_iterator<identity> and drop result_of_adaptable_function (#3652) Thrust's transform_iterator relied on thrust::identity<T>::result_type via result_of_adaptable_function to avoid dangling references. However, thrust::identity<void>, cuda::std::identity, and the placeholder expression _1 have the same issue without a workaround. This change centralizes and adds workarounds for all of these by introducing a new trait thrust::detail::transform_iterator_reference, which decays the return value type of any of the aforementioned function objects. * Deprecate and replace thrust::identity (#3649) Co-authored-by: Michael Schellenberger Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.