-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] [refactoring] Replace MidCircuitMeasurementAnalyzer
with existing quake-add-metadata
pass
#2610
Draft
khalatepradnya
wants to merge
5
commits into
NVIDIA:main
Choose a base branch
from
khalatepradnya:fix-issue-2000
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
a78b7ec
to
706f12f
Compare
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
`quake-add-metadata` pass instead. * Temporary: Handful for state prep / init tests fail to compile due to potential issues in capturing data from parent scope - marked them as skipped.
* Removed the skipping of Python tests ----------------------- Signed-off-by: Pradnya Khalate <[email protected]> Co-authored-by: Anna Gringauze <[email protected]>
destructor for CapturedDataStorage * Renamed duplicate kernels - need to investigate if this points to an underlying bug. Without this, when running the full test suite, we get error like - `RuntimeError: python alt_launch_kernel failed to get set cudaq state function for kernel: kernel` All tests run successfully standalone. * Spell check - removed commented lines of code Signed-off-by: Pradnya Khalate <[email protected]>
ae9a6c6
to
178b6c6
Compare
I, Pradnya Khalate <[email protected]>, hereby add my Signed-off-by to this commit: 27b2304 Signed-off-by: Pradnya Khalate <[email protected]>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May need follow-up: Data capture logic.
Addresses issue #2000