Add Dell Precision 5520 (based on 5530) #1398
Conversation
| @@ -81,6 +81,7 @@ | |||
| dell-poweredge-r7515 = import ./dell/poweredge/r7515; | |||
| dell-precision-3541 = import ./dell/precision/3541; | |||
| dell-precision-5490 = import ./dell/precision/5490; | |||
| dell-precision-5520 = import ./dell/precision/5520; | |||
There was a problem hiding this comment.
Please also add this model to the README.md table. Otherwise our CI doesn't test this.
| open = lib.mkDefault false; | ||
| nvidiaSettings = lib.mkDefault true; | ||
| modesetting.enable = lib.mkDefault true; | ||
| package = lib.mkDefault config.boot.kernelPackages.nvidiaPackages.stable; |
|
|
||
| hardware = { | ||
| nvidia = { | ||
| open = lib.mkDefault false; |
There was a problem hiding this comment.
Afaik we do set this in nvidia generation specific profiles i.e. ../../../common/gpu/nvidia/maxwell
| hardware = { | ||
| nvidia = { | ||
| open = lib.mkDefault false; | ||
| nvidiaSettings = lib.mkDefault true; |
There was a problem hiding this comment.
| }; | ||
| }; | ||
| }; | ||
| # This will save you money and possibly your life! |
|
@Mic92 Thank you for the review. I have blatantly stolen the config from the 5530 which is almost identical. In fact only lines 7 and 9 are different: https://github.com/cjdell/nixos-hardware/blob/master/dell/precision/5530/default.nix I may be out of my depth here but if you think there are improvements to be made then that would appear to be true of the 5530 model config as well which was merged 3 months ago. I deliberately made as few changes as possible. |
Description of changes
Added the definition for Dell Precision 5520 using the already existing 5530 as a template.
Confirmed nVidia hybrid graphics are working.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input