-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dell Precision 5520 (based on 5530) #1398
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
{ lib, config, ... }: | ||
|
||
{ | ||
imports = [ | ||
../../../common/pc/laptop | ||
../../../common/pc/laptop/ssd | ||
../../../common/gpu/nvidia/maxwell | ||
../../../common/gpu/nvidia/prime.nix | ||
../../../common/cpu/intel/kaby-lake | ||
]; | ||
|
||
boot = { | ||
kernelParams = [ | ||
# fix lspci hanging with nouveau | ||
# source https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1803179/comments/149 | ||
"acpi_rev_override=1" | ||
"acpi_osi=Linux" | ||
"nouveau.modeset=0" | ||
"pcie_aspm=force" | ||
"drm.vblankoffdelay=1" | ||
"nouveau.runpm=0" | ||
"mem_sleep_default=deep" | ||
# fix flicker | ||
# source https://wiki.archlinux.org/index.php/Intel_graphics#Screen_flickering | ||
"i915.enable_psr=0" | ||
"nvidia_drm.modeset=1" | ||
]; | ||
}; | ||
|
||
hardware = { | ||
nvidia = { | ||
open = lib.mkDefault false; | ||
nvidiaSettings = lib.mkDefault true; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
modesetting.enable = lib.mkDefault true; | ||
package = lib.mkDefault config.boot.kernelPackages.nvidiaPackages.stable; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this not the default? |
||
prime = { | ||
intelBusId = lib.mkDefault "PCI:0:2:0"; | ||
nvidiaBusId = lib.mkDefault "PCI:1:0:0"; | ||
}; | ||
}; | ||
}; | ||
# This will save you money and possibly your life! | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment is in the wrong line. |
||
services = { | ||
fwupd.enable = lib.mkDefault true; | ||
thermald.enable = lib.mkDefault true; | ||
}; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,6 +81,7 @@ | |
dell-poweredge-r7515 = import ./dell/poweredge/r7515; | ||
dell-precision-3541 = import ./dell/precision/3541; | ||
dell-precision-5490 = import ./dell/precision/5490; | ||
dell-precision-5520 = import ./dell/precision/5520; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please also add this model to the README.md table. Otherwise our CI doesn't test this. |
||
dell-precision-5530 = import ./dell/precision/5530; | ||
dell-precision-5560 = import ./dell/precision/5560; | ||
dell-precision-7520 = import ./dell/precision/7520; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik we do set this in nvidia generation specific profiles i.e.
../../../common/gpu/nvidia/maxwell