Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] ddmrp: Refactoring of incomings calculation #311

Closed
wants to merge 1 commit into from
Closed

[14.0][IMP] ddmrp: Refactoring of incomings calculation #311

wants to merge 1 commit into from

Conversation

BernatPForgeFlow
Copy link
Member

@BernatPForgeFlow BernatPForgeFlow commented Aug 3, 2023 •
edited
Loading

Refactoring of incomings calculation

  1. Reformulate incoming quantities calculation
    Split incoming quantities between inside or outside DLT. Make it more heritable, to facilitate consideration of other data sources. Store all the incoming moves and rfqs to always show what was calculated the last time it was refreshed.

  2. Add customized Stock Moves view
    When checking incoming quantities or qualified demand moves, we will use a customized view that allows to redirect to the source document of that move.

Other changes:

  • A change is made to the DLT date limit calculation so that refreshing a buffer prior to 12:00:00 UCT, take into account DLT date limit supplies.
  • In the calculation of the arrival quantities, the case of receptions in more than one step is taken into account. In these cases there was the possibility of double counting the RFQ and the Stock Move of arrival.

@OCA-git-bot
Copy link
Contributor

Hi @JordiBForgeFlow, @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

LoisRForgeFlow
LoisRForgeFlow reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you are tackling this... Does this work fine with manufactured items? and if you have manufacturing in 3 steps?

ddmrp/models/stock_buffer.py Outdated Show resolved Hide resolved
@BernatPForgeFlow BernatPForgeFlow mentioned this pull request Aug 23, 2023
Closed
@BernatPForgeFlow BernatPForgeFlow force-pushed the 14.0-imp-ddmrp-outside_dlt branch 2 times, most recently from 601aef9 to e676412 Compare August 25, 2023 15:04
@BernatPForgeFlow
Copy link
Member Author

Now that you are tackling this... Does this work fine with manufactured items? and if you have manufacturing in 3 steps?

@LoisRForgeFlow I have added 4 tests that check if it works for purchased and manufactured items with 1 or 3 step manufacturing.

@BernatPForgeFlow BernatPForgeFlow force-pushed the 14.0-imp-ddmrp-outside_dlt branch 2 times, most recently from 7b5ce01 to dedd7fa Compare November 21, 2023 14:04
@BernatPForgeFlow BernatPForgeFlow changed the title [14.0][IMP] ddmrp: Add 'total_outside_dlt_qty' to split incoming moves than rfqs [14.0][IMP] ddmrp: Refactoring of incomings calculation Nov 21, 2023
@BernatPForgeFlow BernatPForgeFlow force-pushed the 14.0-imp-ddmrp-outside_dlt branch 3 times, most recently from 2e70126 to c22db19 Compare November 28, 2023 09:24
@LoisRForgeFlow LoisRForgeFlow mentioned this pull request Dec 7, 2023
Closed
@PauBForgeFlow PauBForgeFlow mentioned this pull request Dec 27, 2023
Closed
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 31, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 5, 2024
@BernatPForgeFlow BernatPForgeFlow force-pushed the 14.0-imp-ddmrp-outside_dlt branch 2 times, most recently from ed1b05b to f4ff23f Compare May 10, 2024 07:36
@BernatPForgeFlow
[IMP] ddmrp: Reformulate incoming quantities calculation
71e02cb 
Split incoming quantities between inside or outside DLT.
Make it more heritable, to facilitate consideration of other data sources.

Other changes:
- A change is made to the DLT date limit calculation so that refreshing a buffer prior to 12:00:00 UCT, take into account DLT date limit supplies.
- In the calculation of the arrival quantities, the case of receptions in more than one step is taken into account. In these cases there was the possibility of double counting the RFQ and the Stock Move of arrival.
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 15, 2024
@github-actions github-actions bot closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow left review comments

Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BernatPForgeFlow @OCA-git-bot @LoisRForgeFlow