Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] fieldservice_portal: Migration to 17.0 #1252

Open
wants to merge 7 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] fieldservice_portal: Migration to 17.0 #1252

wants to merge 7 commits into from
+1,838 −0

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Oct 28, 2024 •
edited
Loading

@max3903 max3903 added this to the 17.0 milestone Oct 29, 2024
@max3903 max3903 self-assigned this Oct 29, 2024
@max3903
Copy link
Member

max3903 commented Oct 29, 2024

@peluko00 Not a show stopper, but if you can add some description and the FSM icon on the portal that would look much nicer and consistent:
image

ppyczko
ppyczko approved these changes Oct 30, 2024
View reviewed changes
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

mpascuall
mpascuall approved these changes Oct 30, 2024
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@peluko00
Copy link
Contributor Author

@peluko00 Not a show stopper, but if you can add some description and the FSM icon on the portal that would look much nicer and consistent: image

Done, thanks!

BernatObrador
BernatObrador approved these changes Oct 30, 2024
View reviewed changes
Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ivantodorovich
ivantodorovich approved these changes Dec 2, 2024
View reviewed changes
Copy link

@ivantodorovich ivantodorovich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LG.

Could you check the pre-commit issue? CI is red due to this

****po-syntax-error****
fieldservice_portal/i18n/es.po:1 Syntax error in po file (line 67): unescaped double quote found - [po-syntax-error]

@peluko00
Copy link
Contributor Author

peluko00 commented Dec 3, 2024

@max3903 seems it's ready to merge

@ivantodorovich
Copy link

Actually, @peluko00 , there's still the pre-commit issue I mentioned on my last comment.

****po-syntax-error****
fieldservice_portal/i18n/es.po:1 Syntax error in po file (line 67): unescaped double quote found - [po-syntax-error]

https://github.com/OCA/field-service/actions/runs/11589402819/job/32264841574?pr=1252

Could you check it out?

@peluko00
Copy link
Contributor Author

peluko00 commented Dec 3, 2024 •
edited
Loading

Actually, @peluko00 , there's still the pre-commit issue I mentioned on my last comment.

****po-syntax-error****
fieldservice_portal/i18n/es.po:1 Syntax error in po file (line 67): unescaped double quote found - [po-syntax-error]

https://github.com/OCA/field-service/actions/runs/11589402819/job/32264841574?pr=1252

Could you check it out?

Done, can you retry? Thanks! @ivantodorovich

@ivantodorovich
Copy link

Looks good now 👍🏻
Thanks a lot! ❤️

I have no merge powers here, but I'm sure someone from the PSC will merge it asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppyczko ppyczko ppyczko approved these changes

@mpascuall mpascuall mpascuall approved these changes

@BernatObrador BernatObrador BernatObrador approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@max3903 max3903 max3903 approved these changes

Assignees

@max3903 max3903

Labels
approved migration needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
10 participants
@peluko00 @max3903 @ivantodorovich @marcelsavegnago @BernatObrador @mpascuall @ppyczko @OCA-git-bot @renda-dev @anusriNPS