Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] fieldservice_project #772

Merged
merged 27 commits into from
Apr 28, 2021

Conversation

baimont
Copy link
Contributor

@baimont baimont commented Apr 26, 2021

Migration of fieldservice_project to 13.0

#354

I'll add tests when I find some time.

patrickrwilson and others added 26 commits April 26, 2021 14:39
This adds a module to allow field service orders to be created from projects and project tasks.
updated with reviewer suggestions.
fixed lint error (missing OCA in authors)
Currently translated at 100.0% (12 of 12 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_project
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_project/de/
Currently translated at 100.0% (12 of 12 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_project
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_project/es_CL/
Currently translated at 100.0% (12 of 12 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_project
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_project/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-12.0/field-service-12.0-fieldservice_project
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_project/
Currently translated at 100.0% (13 of 13 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_project
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_project/pt_BR/
Currently translated at 100.0% (13 of 13 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_project
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_project/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-12.0/field-service-12.0-fieldservice_project
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_project/
@brian10048 brian10048 added this to the 13.0 milestone Apr 26, 2021
@brian10048 brian10048 mentioned this pull request Apr 26, 2021
43 tasks
@marcelsavegnago
Copy link
Member

@baimont Very good work. Can you implement some tests to improve coverage?

Copy link
Contributor

@brian10048 brian10048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on the test coverage. Greatly appreciated

@marcelsavegnago
Copy link
Member

@baimont Very good! Thanks. Congratulations

@brian10048
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-772-by-brian10048-bump-nobump, awaiting test results.

Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional testing at runbot http://3479579-772-d64219.runbot1-2.odoo-community.org/web

Project > FSM order failed to carry default project. It remains empty.

Tasks > FSM order works well, carry default tasks and assign it correctly.

@OCA-git-bot OCA-git-bot merged commit 7d2ee95 into OCA:13.0 Apr 28, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bbab698. Thanks a lot for contributing to OCA. ❤️

@brian10048
Copy link
Contributor

Thanks for the thorough review @bodedra. I guess I merged this one a little too soon.

I opened #774 to help us keep track. I tested on v12 runbot and it appears the bug is there as well.

@bodedra
Copy link
Member

bodedra commented Apr 28, 2021

Thanks for reporting issue @brian10048

I feel I reviewed little late. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.