[MIG] project_task_code: Migration to 17.0 #1355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCA Transbot updated translations from Transifex [MIG] project_task_code: Migrate to 10.0 Edit init and XML Add env Change task_ids to tasks Change to @api.multi before def copy
Relational fields and the task notification email inform the task code
- adapted view (label needs a `for` attribute, use span for same result) - use the `model_create_multi` decorator on the create override for future-proofiness
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (3 of 3 strings) Translation: project-12.0/project-12.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_code/gl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-13.0/project-13.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_task_code/
The overload of project.task::create in the project_task_code would mutate the dictionaries passed in the vals_list argument. This is a bad practice which can have unintended side effects in caller code. We fix this by creating a new dictionary containing the additional field value and passing this dictionary in the call to super().create()
…olates not-null constraint
Currently, the sequence that generates task codes is only available for the main company [1], which could cause issues at the moment of the installation process with another modules in multi-companies cases, for example project_timesheet_holiday [2] because in the other companies, this line [3] will return False or "/" and will trigger the UNIQUE constraint. With this change, the sequence can be used by any company [4] using the False value in the field company_id. References: [1] https://github.com/odoo/odoo/blob/7b6c25e/odoo/addons/base/models/ir_sequence.py#L148 [2] https://github.com/odoo/odoo/blob/7b6c25e/addons/project_timesheet_holidays/models/res_company.py#L14 [3] https://github.com/OCA/project/blob/9d08f2d/project_task_code/models/project_task.py#L29 [4] https://github.com/odoo/odoo/blob/7b6c25e/odoo/addons/base/models/ir_sequence.py#L282
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/
Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/it/
Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/es/
Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/es_AR/
Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/it/
Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/pt_BR/
Search task by its code in x2m fields.
|
Looks good to me! |
n17
approved these changes
Oct 25, 2024
coleste
reviewed
Nov 22, 2024
| </xpath> | ||
| <field name="name" position="before"> | ||
| <field name="code" /> | ||
| </field> |
There was a problem hiding this comment.
This revert is weird. I don't think it works.
16.0 has a t-if= / t-else=, same as 17.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.