[MIG] project_task_code: Migration to 17.0

project_task_code/README.rst

@@ -89,6 +89,7 @@ Contributors
 - Saran Lim. <[email protected]>
 - Tharathip Chaweewongphan <[email protected]>
 - Ruchir Shukla <[email protected]>
+- Nedas Žilinskas <[email protected]>
 
 Maintainers
 -----------

project_task_code/__manifest__.py

@@ -3,7 +3,7 @@
 
 {
     "name": "Sequential Code for Tasks",
-    "version": "16.0.1.1.0",
+    "version": "17.0.1.0.0",
     "category": "Project Management",
     "author": "OdooMRP team, "
     "AvanzOSC, "

project_task_code/hooks.py

@@ -1,30 +1,27 @@
 # Copyright 2016 Tecnativa <[email protected]>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import SUPERUSER_ID, api
 
-
-def pre_init_hook(cr):
+def pre_init_hook(env):
     """
     With this pre-init-hook we want to avoid error when creating the UNIQUE
     code constraint when the module is installed and before the post-init-hook
     is launched.
     """
-    cr.execute("ALTER TABLE project_task ADD COLUMN code character varying;")
-    cr.execute("UPDATE project_task SET code = id;")
+    env.cr.execute("ALTER TABLE project_task ADD COLUMN code character varying;")
+    env.cr.execute("UPDATE project_task SET code = id;")
 
 
-def post_init_hook(cr, registry):
+def post_init_hook(env):
     """
     This post-init-hook will update all existing task assigning them the
     corresponding sequence code.
     """
-    env = api.Environment(cr, SUPERUSER_ID, dict())
     task_obj = env["project.task"]
     sequence_obj = env["ir.sequence"]
     tasks = task_obj.search([], order="id")
     for task_id in tasks.ids:
-        cr.execute(
+        env.cr.execute(
             "UPDATE project_task SET code = %s WHERE id = %s;",
             (
                 sequence_obj.next_by_code("project.task"),

project_task_code/models/project_task.py

@@ -3,6 +3,10 @@
 
 from odoo import _, api, fields, models
 
+PROJECT_TASK_WRITABLE_FIELDS = {
+    "code",
+}
+
 
 class ProjectTask(models.Model):
     _inherit = "project.task"
@@ -24,21 +28,21 @@
         ),
     ]
 
+    @property
+    def SELF_WRITABLE_FIELDS(self):
+        return super().SELF_WRITABLE_FIELDS | PROJECT_TASK_WRITABLE_FIELDS
+
     @api.model_create_multi
     def create(self, vals_list):
         for vals in vals_list:
             if vals.get("code", "/") == "/":
                 vals["code"] = (
-                    self.env["ir.sequence"].next_by_code("project.task") or "/"
+                    # `sudo()` for portal users
+                    self.env["ir.sequence"].sudo().next_by_code("project.task") or "/"
                 )
         return super().create(vals_list)
 
-    def name_get(self):
-        result = super().name_get()
-        new_result = []
-
-        for task in result:
-            rec = self.browse(task[0])
-            name = f"[{rec.code}] {task[1]}"
-            new_result.append((rec.id, name))
-        return new_result
+    @api.depends("name", "code")
+    def _compute_display_name(self):
+        for task in self:
+            task.display_name = f"[{task.code}] {task.name}" if task.code else task.name

project_task_code/readme/CONTRIBUTORS.md

@@ -9,3 +9,4 @@
 - Saran Lim. \<<[email protected]>\>
 - Tharathip Chaweewongphan \<<[email protected]>\>
 - Ruchir Shukla \<<[email protected]>\>
+- Nedas Žilinskas \<<[email protected]>\>

project_task_code/static/description/index.html

@@ -435,6 +435,7 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 <li>Saran Lim. &lt;<a class="reference external" href="mailto:saranl&#64;ecosoft.co.th">saranl&#64;ecosoft.co.th</a>&gt;</li>
 <li>Tharathip Chaweewongphan &lt;<a class="reference external" href="mailto:tharathipc&#64;ecosoft.co.th">tharathipc&#64;ecosoft.co.th</a>&gt;</li>
 <li>Ruchir Shukla &lt;<a class="reference external" href="mailto:ruchir&#64;bizzappdev.com">ruchir&#64;bizzappdev.com</a>&gt;</li>
+<li>Nedas Žilinskas &lt;<a class="reference external" href="mailto:nedas.zilinskas&#64;avoin.systems">nedas.zilinskas&#64;avoin.systems</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

project_task_code/tests/test_project_task_code.py

@@ -36,8 +36,8 @@ def test_name_get(self):
                 "name": "Task Testing Get Name",
             }
         )
-        result = project_task.name_get()
-        self.assertEqual(result[0][1], "[%s] Task Testing Get Name" % code)
+        result = project_task.display_name
+        self.assertEqual(result, "[%s] Task Testing Get Name" % code)
 
     def test_name_search(self):
         project_task = self.env["project.task"].create(

project_task_code/views/project_view.xml

@@ -26,18 +26,9 @@
         <field name="model">project.task</field>
         <field name="inherit_id" ref="project.view_task_kanban" />
         <field name="arch" type="xml">
-            <xpath
-                expr="//strong[hasclass('o_kanban_record_title')]/t/field[@name='name']"
-                position="before"
-            >
-                <span>[<field name="code" />] </span>
-            </xpath>
-            <xpath
-                expr="//strong[hasclass('o_kanban_record_title')]/s/field[@name='name']"
-                position="before"
-            >
-                <span>[<field name="code" />] </span>
-            </xpath>
+            <field name="name" position="before">
+                <field name="code" />
+            </field>
         </field>
     </record>
     <record id="project_task_code_search_view" model="ir.ui.view">