Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] auth_user_case_insensitive: Migration to 15.0 #361

Closed
wants to merge 26 commits into from
Closed

[15.0][MIG] auth_user_case_insensitive: Migration to 15.0 #361

wants to merge 26 commits into from

Conversation

Herqs
Copy link
Contributor

@Herqs Herqs commented Mar 28, 2022

No description provided.

Ted Salmon and others added 25 commits March 25, 2022 13:21
@Herqs
[IMP] auth_user_case_insensitive: Update module name
710a4cb
@Herqs
[IMP] auth_user_case_insensitive: Drop search() override in favor o…
3eb411a 
…f `_login`

* Update code and tests to override `_login` method
@dreispt @Herqs
Note that existing logins are converted to lowercase
634089a
@oca-transbot @Herqs
OCA Transbot updated translations from Transifex
a949f8e
@oca-travis @Herqs
[UPD] Update auth_user_case_insensitive.pot
6f3ae6c
@mgosai @Herqs
[FIX/IMP] Fixed code for migration from v10 to v11 as per OCA standards.
add0013
@mgosai @Herqs
[FIX] Fixed minor missing changes
850834b
@Herqs
Update __manifest__.py
d14c57b
@max3903 @Herqs
Update DESCRIPTION.rst
689a33c
@max3903 @Herqs
Update INSTALL.rst
300c18a
@OCA-git-bot @Herqs
[UPD] README.rst
6bf12ad
@OCA-git-bot @Herqs
[UPD] README.rst
730900a
@oca-travis @Herqs
[UPD] Update auth_user_case_insensitive.pot
b32709e
@oca-transbot @Herqs
Update translation files
c5d1585 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@OCA-git-bot @Herqs
[ADD] icon.png
3a06026
@Herqs
[MIG] auth_user_case_insensitive: Migration to 12.0
c452a38
@remytms @Herqs
[FIX] auth_user_case_insensitive: LDAP error in tests
3a750e4
@OCA-git-bot @Herqs
[UPD] README.rst
83b3c89
@Herqs
Translated using Weblate (Portuguese (Brazil))
573a1e4 
Currently translated at 100.0% (2 of 2 strings)

Translation: server-auth-12.0/server-auth-12.0-auth_user_case_insensitive
Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-auth_user_case_insensitive/pt_BR/
@Chandresh-SerpentCS @Herqs
[MIG][13.0] Migrated the module in v13.
edfcf5d
@oca-travis @Herqs
[UPD] Update auth_user_case_insensitive.pot
9fadb25
@oca-transbot @Herqs
Update translation files
3581ce7 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-auth-13.0/server-auth-13.0-auth_user_case_insensitive
Translate-URL: https://translation.odoo-community.org/projects/server-auth-13-0/server-auth-13-0-auth_user_case_insensitive/
@Chandresh-SerpentCS @Herqs
[MIG] Module migrated in v14.
8082d72
@oca-travis @Herqs
[UPD] Update auth_user_case_insensitive.pot
cc8fc7f
@OCA-git-bot @Herqs
[UPD] README.rst
8f26d82
@Herqs Herqs changed the title Mig/1048 user case insensitive hml [15.0][MIG] auth_user_case_insensitive: Migration to 15.0 Mar 28, 2022
@flachica
Copy link
Contributor

I think that you should comment in #299 to point to this PR

This was referenced Mar 30, 2022
Closed
Merged
@Herqs Herqs force-pushed the mig/1048-user-case-insensitive-hml branch from d44a4ea to e1f7327 Compare April 6, 2022 12:47
@Herqs Herqs force-pushed the mig/1048-user-case-insensitive-hml branch from e1f7327 to 6a01560 Compare April 7, 2022 11:00
@Herqs
Copy link
Contributor Author

Herqs commented Apr 8, 2022

Hello @guimarc-br

I've doublechecked, it seems that user_agent_env was added as a parameter to res_user._login method on v14. It was added to this module during v14 migration in this commit: c19ad6c

Kind regards

@Herqs Herqs force-pushed the mig/1048-user-case-insensitive-hml branch 2 times, most recently from c468a99 to 22c41d7 Compare April 11, 2022 08:44
@Herqs Herqs force-pushed the mig/1048-user-case-insensitive-hml branch from 22c41d7 to da63b64 Compare April 11, 2022 08:48
kanda999
kanda999 approved these changes Jun 10, 2022
View reviewed changes
Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review : Working as expected

@henryjiang-willdooit henryjiang-willdooit mentioned this pull request Jun 28, 2022
Closed
@pedrobaeza
Copy link
Member

/ocabot migration auth_user_case_insensitive

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jun 28, 2022
@CRogos
Copy link
Contributor

CRogos commented Jul 12, 2022

What is missing on this PR?
Is the failed check really related to the changes by this PR?

@CRogos
Copy link
Contributor

CRogos commented Aug 10, 2022

Code review: LGTM!

@CRogos
Copy link
Contributor

CRogos commented Sep 20, 2022

@pedrobaeza could you have a look? Could you trigger the merge?

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-361-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 20, 2022
@OCA-git-bot
Merge PR #361 into 15.0
f4a5499 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-361-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@CRogos
Copy link
Contributor

CRogos commented Sep 23, 2022

@pedrobaeza what needs to be done?

@pedrobaeza
Copy link
Member

Please rebase and check the CI.

@CRogos
Copy link
Contributor

CRogos commented Sep 26, 2022

@Herqs could you rebase your PR?

@dreispt
Copy link
Member

dreispt commented Oct 1, 2022

/ocabot merge rebase

@OCA-git-bot
Copy link
Contributor

Hi @dreispt. Your command failed:

Invalid options for command merge: rebase.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase* ocabot migration {MODULE_NAME}

More information

@CRogos CRogos mentioned this pull request Oct 5, 2022
Merged
@dreispt
Copy link
Member

dreispt commented Oct 6, 2022

Superseded by #428

@dreispt dreispt closed this Oct 6, 2022
SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#361 from OCA/11.0
8b6e2d4 
Syncing from upstream OCA/server-auth (11.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanda999 kanda999 kanda999 approved these changes

@CRogos CRogos CRogos approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.