Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] web_widget_x2many_2d_matrix: fix to prevent errors and update readme usage #3116

Open
wants to merge 3 commits into
base: 17.0
Choose a base branch
from

Conversation

cuongnmtm
Copy link
Contributor

@cuongnmtm cuongnmtm commented Mar 8, 2025

1. Fix the issue reported here #3093 (comment) (1st commit).

Steps to reproduce:

  • Test with the field of field_value has no domain specified, or domain = [] (domain = "[]" still works)

2. Fix the issue where an error is raised when no record exists for a cell (2nd commit).

W/o the fix (2 errors):

image image

With the fix:

image

3. Update the readme usage cause Odoo renamed some fields.

@OCA-git-bot
Copy link
Contributor

Hi @JasminSForgeFlow,
some modules you are maintaining are being modified, check this out!

@cuongnmtm cuongnmtm force-pushed the 17.0-fix-field_value-no-domain branch 2 times, most recently from cb06722 to bd70877 Compare March 8, 2025 18:22
@cuongnmtm cuongnmtm force-pushed the 17.0-fix-field_value-no-domain branch from bd70877 to 1569bc0 Compare March 8, 2025 18:33
@cuongnmtm cuongnmtm changed the title [FIX] web_widget_x2many_2d_matrix: Handle missing domain condition to… [IMP] web_widget_x2many_2d_matrix: fix to prevent errors and update readme usage Mar 8, 2025
@cuongnmtm cuongnmtm changed the title [IMP] web_widget_x2many_2d_matrix: fix to prevent errors and update readme usage [17.0][IMP] web_widget_x2many_2d_matrix: fix to prevent errors and update readme usage Mar 8, 2025
@JasminSForgeFlow
Copy link
Contributor

@cuongnmtm domain issue hasn't occurred to me while testing a field without a domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants