[Integrate-1825] WhiteRabbit switch to cmd line interface #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KangJingA
requested review from
csafreen,
SantanM,
satish-a0,
suwarnoong and
p-hoffmann
as code owners
Comment on lines
76
to
77
| ShellOperation( | ||
| commands=["Xvfb :1"]).trigger() |
There was a problem hiding this comment.
Do we instead want to use start_awt_display function here
| headers: { | ||
| "Content-Type": "application/json", | ||
| }, | ||
| username: "admin", |
There was a problem hiding this comment.
Do we want to remove username here
hengxian-jiang
approved these changes
Apr 14, 2025
p-hoffmann
approved these changes
Apr 17, 2025
suwarnoong
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)