Skip to content

[internal-1828] upgrade Strategus version, remove keyring creation and its references #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[internal-1828] upgrade Strategus version, remove keyring creation and its references #38

wants to merge 1 commit into from

Conversation

SantanM
Copy link
Collaborator

@SantanM SantanM commented Apr 11, 2025

Merge Checklist

Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.

  • Automated Tests (Jasmine integration tests, Unit tests, and/or Performance tests)
  • Updated Manual tests / Demo Config
  • Documentation (Application guide, Admin guide, Markdown, Readme and/or Wiki)
  • Verified that local development environment is working with latest changes (integrated with latest develop branch)
  • following best practices in code review doc

@SantanM SantanM changed the title upgrade Strategus version, remove keyring creation and its references [internal-1828] upgrade Strategus version, remove keyring creation and its references Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csafreen csafreen Awaiting requested review from csafreen csafreen will be requested when the pull request is marked ready for review csafreen is a code owner

@satish-a0 satish-a0 Awaiting requested review from satish-a0 satish-a0 will be requested when the pull request is marked ready for review satish-a0 is a code owner

@suwarnoong suwarnoong Awaiting requested review from suwarnoong suwarnoong will be requested when the pull request is marked ready for review suwarnoong is a code owner

@p-hoffmann p-hoffmann Awaiting requested review from p-hoffmann p-hoffmann will be requested when the pull request is marked ready for review p-hoffmann is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SantanM