Allow pulling git-lfs files in Azure CI #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ran into the issue of Azure not pulling git-lfs files during PlasmaPy/PlasmaPy-NEI#21 As it turns out, adding `lfs: true` to the `checkout` step as in this change: PlasmaPy/PlasmaPy-NEI@d3360c3 allows Azure to pull LFS files. This change was guided by Azure docs over at https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/pipeline-options-for-git?view=azure-devops#checkout-files-from-lfs
3 tasks
|
I assume this doesn't cause any issues for repos not using lfs? |
|
I expect so - I wouldn't see it breaking anything if LFS isn't used. |
|
let's find out 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into the issue of Azure not pulling git-lfs files during
PlasmaPy/PlasmaPy-NEI#21
As it turns out, adding
lfs: trueto thecheckoutstepas in this change:
PlasmaPy/PlasmaPy-NEI@d3360c3
allows Azure to easily grab them.
This change was guided by Azure docs over at
https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/pipeline-options-for-git?view=azure-devops#checkout-files-from-lfs
I didn't see any easy way of overriding this setting downstream, and I currently see no disadvantages to putting it in upstream.