Fix LFS errors for #20

[StanczakDominik]

This is a temporary draft PR so I can experiment with CI and LFS
to fix #20's test failures while not polluting that commit tree.

Before merging:

• git revert 0de1536011941b3e366669f790ba9a26664ee7c2 035beb2239a7b8cc7b14d790d7d07d4d65d7eaca d3360c3cba0fe95e949ec7d0cc35495c7929e8c1 adbc98b43dddd6becff51eaac9d0bc5b47e2465c if Allow pulling git-lfs files in Azure CI OpenAstronomy/azure-pipelines-templates#40 is accepted, otherwise make it an issue
• Ensure lfs bandwidth sanity on circleci: https://www.develer.com/en/avoiding-git-lfs-bandiwdth-waste-with-github-and-circleci/
• Ensure lfs bandwidth sanity on travis: https://docs.travis-ci.com/user/customizing-the-build/#git-lfs

[pep8speaks]

Hello @StanczakDominik! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file plasmapy_nei/eigen/eigenclass.py:

Line 67:27: E203 whitespace before ':'

• In the file plasmapy_nei/nei/nei.py:

Line 17:1: E303 too many blank lines (3)
Line 37:1: E302 expected 2 blank lines, found 3
Line 406:89: E501 line too long (104 > 88 characters)
Line 991:89: E501 line too long (91 > 88 characters)
Line 1120:61: E203 whitespace before ':'
Line 1167:53: E203 whitespace before ':'
Line 1173:9: E731 do not assign a lambda expression, use a def

Comment last updated at 2020-05-01 10:14:39 UTC

[codecov]

Codecov Report

Merging #21 into master will decrease coverage by 18.82%.
The diff coverage is 81.15%.

@@             Coverage Diff              @@
##            master      #21       +/-   ##
============================================
- Coverage   100.00%   81.17%   -18.83%     
============================================
  Files            2        4        +2     
  Lines            4      712      +708     
============================================
+ Hits             4      578      +574     
- Misses           0      134      +134     

Impacted Files	Coverage Δ
plasmapy_nei/nei/nei.py	79.43% <79.39%> (-20.57%)	⬇️
plasmapy_nei/eigen/eigenclass.py	86.11% <86.11%> (ø)
plasmapy_nei/eigen/__init__.py	100.00% <100.00%> (ø)
plasmapy_nei/nei/__init__.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1137689...828d435. Read the comment docs.

[StanczakDominik]

Gotcha! As per the docs at https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/pipeline-options-for-git?view=azure-devops#checkout-files-from-lfs, it's the lack of this line in the OpenAstro run-tox-env.yaml template that's causing the LFS file not to get pulled during the checkout stage:

https://github.com/PlasmaPy/PlasmaPy-NEI/pull/21/files#diff-fa9e59b6afe6a6ecdc0d1ee19d3befaeR59

I'm opening up a PR there.

[StanczakDominik]

Okay @namurphy, that should do the trick. It's probably best if you merge this branch into your PR before doing any further work there.

[StanczakDominik]

For some reason the windows tox test is taking a good while longer. That's strange...

[StanczakDominik]

the wheel and sdist tests are failing, the low-ish (I think...) size of the built package as per https://dev.azure.com/plasmapy/PlasmaPy-NEI/_build/results?buildId=778&view=logs&j=f7656e4a-aab1-5409-7a28-08f0d640eba6&t=a9542dd9-4ae8-5071-2817-2d1dda94f840&l=64 seems to imply the h5 file is not getting included in the sdist itself... A package_data issue?

[StanczakDominik]

I've reverted the changes as lfs: true is now upstream :)