Skip to content

Commit

Permalink
sonar fixes #verification #sonar #docs
Browse files Browse the repository at this point in the history
  • Loading branch information
serges147 committed Dec 3, 2024
1 parent 25be9de commit b8d8b55
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 7 deletions.
6 changes: 5 additions & 1 deletion include/libcyphal/application/node/get_info_provider.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ namespace node
///
/// Internally, it uses the 'GetInfo' service server to handle incoming requests.
///
class GetInfoProvider final
/// No Sonar cpp:S3624 "Customize this class' destructor to participate in resource management."
/// We need custom move constructor to reset up the request callback,
/// but at the destructor level, we don't need to do anything.
///
class GetInfoProvider final // NOSONAR cpp:S3624
{
using Service = uavcan::node::GetInfo_1_0;

Expand Down
6 changes: 5 additions & 1 deletion include/libcyphal/application/node/heartbeat_producer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@ namespace node
///
/// Internally, it uses the 'Heartbeat' message publisher to periodically publish heartbeat messages.
///
class HeartbeatProducer final
/// No Sonar cpp:S3624 "Customize this class' destructor to participate in resource management."
/// We need custom move constructor to reset up the publishing callback,
/// but at the destructor level, we don't need to do anything.
///
class HeartbeatProducer final // NOSONAR cpp:S3624
{
public:
/// @brief Defines the message type for the Heartbeat.
Expand Down
6 changes: 5 additions & 1 deletion include/libcyphal/application/node/registry_provider.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ namespace node
///
/// Internally, it uses the registry 'List' and 'Access' service servers to handle incoming requests.
///
class RegistryProvider final
/// No Sonar cpp:S3624 "Customize this class' destructor to participate in resource management."
/// We need custom move constructor to reset up the request callback,
/// but at the destructor level, we don't need to do anything.
///
class RegistryProvider final // NOSONAR cpp:S3624
{
using ListService = uavcan::_register::List_1_0;
using AccessService = uavcan::_register::Access_1_0;
Expand Down
2 changes: 1 addition & 1 deletion include/libcyphal/transport/can/msg_rx_session.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace detail

/// @brief A class to represent a message subscriber RX session.
///
class MessageRxSession final : IRxSessionDelegate, public IMessageRxSession
class MessageRxSession final : private IRxSessionDelegate, public IMessageRxSession
{
/// @brief Defines private specification for making interface unique ptr.
///
Expand Down
2 changes: 1 addition & 1 deletion include/libcyphal/transport/can/svc_rx_sessions.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ namespace detail
/// Could be either `CanardTransferKindRequest` or `CanardTransferKindResponse`.
///
template <typename Interface_, typename Params, CanardTransferKind TransferKind>
class SvcRxSession final : IRxSessionDelegate, public Interface_
class SvcRxSession final : private IRxSessionDelegate, public Interface_
{
/// @brief Defines private specification for making interface unique ptr.
///
Expand Down
2 changes: 1 addition & 1 deletion include/libcyphal/transport/udp/msg_rx_session.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace detail

/// @brief A class to represent a message subscriber RX session.
///
class MessageRxSession final : IMsgRxSessionDelegate, public IMessageRxSession
class MessageRxSession final : private IMsgRxSessionDelegate, public IMessageRxSession
{
/// @brief Defines private specification for making interface unique ptr.
///
Expand Down
2 changes: 1 addition & 1 deletion include/libcyphal/transport/udp/svc_rx_sessions.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ namespace detail
/// Could be either `RequestRxParams` or `ResponseRxParams`.
///
template <typename Interface_, typename Params, typename SessionEvent, bool IsRequest>
class SvcRxSession final : IRxSessionDelegate, public Interface_
class SvcRxSession final : private IRxSessionDelegate, public Interface_
{
/// @brief Defines private specification for making interface unique ptr.
///
Expand Down

0 comments on commit b8d8b55

Please sign in to comment.