ModbusRecordChannel: fix read error for write-only channels #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May I ask for a review on this and the related PR #2257 ? We use the Edge2Edge-Ess in read-write-mode in two productive systems, and without those PRs it wouldn't work. Thanks. |
# Conflicts: # io.openems.edge.common/src/io/openems/edge/common/modbusslave/ModbusRecordChannel.java
Sury. In fact the problem had been solved in f0b0527#diff-bb02b130c9bfd04e1cdb847b3f138cd028aef03a1770b6bfc9a6bde6894f26ceR120-R124 before - but your solution is better. I merged the changes here in this PR, added a JUnit test and migrated the entire file to switch expressions. |
sfeilmeier
approved these changes
Oct 1, 2023
|
|
sfeilmeier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Edge2EdgeEss tried to read out the write-only channels, causing a read error. This is fixed by setting the modbus register of a write-only channel to "undefined" (like it is done for the registers in between natures).