-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sungrow String and ESS Implementation #2528
Sungrow String and ESS Implementation #2528
Conversation
…com/Sn0w3y/openems into Sungrow-ESS-and-Sungrow-PV-Inverter
We have too many open PRs with similar issues. I suggest we work on #2566 first (see the discussions on Coding Guidelines there). Afterwards we can re-open these PRs one at a time. Thanks! |
Any news on this? |
Closed as i guess it is a WIP |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2528 +/- ##
==============================================
- Coverage 55.89% 25.63% -30.25%
==============================================
Files 2077 254 -1823
Lines 87948 6361 -81587
Branches 6494 953 -5541
==============================================
- Hits 49149 1630 -47519
+ Misses 37115 4657 -32458
+ Partials 1684 74 -1610 |
We are still working on it and we are testing it thoroughly. I will update this PR when we are done. You can merge it yourself and can use it as a starting point. |
Based on the Implementation of @clehne in opernikus-common fork.
I adapted it to use ElectricityMeter
Thanks to them