Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sungrow String and ESS Implementation #2528

Closed

Conversation

Sn0w3y
Copy link
Contributor

@Sn0w3y Sn0w3y commented Feb 7, 2024

Based on the Implementation of @clehne in opernikus-common fork.
I adapted it to use ElectricityMeter

Thanks to them

@clehne clehne requested a review from tsicking March 3, 2024 17:24
@sfeilmeier
Copy link
Contributor

We have too many open PRs with similar issues. I suggest we work on #2566 first (see the discussions on Coding Guidelines there). Afterwards we can re-open these PRs one at a time. Thanks!

@sfeilmeier sfeilmeier marked this pull request as draft March 11, 2024 08:31
Copy link

github-actions bot commented Apr 1, 2024

Code Coverage

@Sn0w3y Sn0w3y marked this pull request as ready for review April 1, 2024 21:26
@Giermann
Copy link

Any news on this?
@tsicking would I be forced to merge the PR myself for my first experience with OpenEMS or is there any schedule planned to accept this PR?

@Sn0w3y Sn0w3y closed this Aug 16, 2024
@Sn0w3y
Copy link
Contributor Author

Sn0w3y commented Aug 16, 2024

Closed as i guess it is a WIP

@Sn0w3y Sn0w3y deleted the Sungrow-ESS-and-Sungrow-PV-Inverter branch August 16, 2024 10:02
@Sn0w3y Sn0w3y restored the Sungrow-ESS-and-Sungrow-PV-Inverter branch August 16, 2024 10:03
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ There is a different number of reports uploaded between BASE (d00e0e9) and HEAD (b8316cb). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d00e0e9) HEAD (b8316cb)
2 1
Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #2528       +/-   ##
==============================================
- Coverage      55.89%   25.63%   -30.25%     
==============================================
  Files           2077      254     -1823     
  Lines          87948     6361    -81587     
  Branches        6494      953     -5541     
==============================================
- Hits           49149     1630    -47519     
+ Misses         37115     4657    -32458     
+ Partials        1684       74     -1610     

@tsicking
Copy link
Contributor

Any news on this? @tsicking would I be forced to merge the PR myself for my first experience with OpenEMS or is there any schedule planned to accept this PR?

We are still working on it and we are testing it thoroughly. I will update this PR when we are done. You can merge it yourself and can use it as a starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants