UI: fix formly form styles #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anslate/core-16.0.3 # Conflicts: # ui/package-lock.json # ui/package.json
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## develop #2962 +/- ##
=============================================
+ Coverage 57.08% 57.08% +0.01%
- Complexity 9729 9732 +3
=============================================
Files 2266 2266
Lines 96819 96819
Branches 7163 7163
=============================================
+ Hits 55260 55264 +4
+ Misses 39498 39493 -5
- Partials 2061 2062 +1 |
|
Looks great again! Thanks @lukasrgr ! |
|
This solves major issues with the version update. |
venu-sagar
approved these changes
Jan 13, 2025
|
@sfeilmeier there would be a permanent solution to this issue, if using labelPlacement floating, this would change the style completely, what do you think? |
|
I could live with the change... https://ionicframework.com/docs/api/input#label-placement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to: #2958
Changes
fixing styles permanently for
component-updateandcomponent-installand all other components, which are using the default formlyfield typeinput