FEMS Backports 2025-01-16 #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed-by: Michael Grill <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Kai Jeschek <[email protected]> Co-committed-by: Kai Jeschek <[email protected]>
Reviewed-by: Lukas Rieger <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: FENECON\anas.shetla <[email protected]> Co-committed-by: FENECON\anas.shetla <[email protected]>
- Moved DebugMode to Common - Added DebugMode to BridgeHttp - Added parameter of type DebugMode to NetworkEndpointFetcher - Added Detailed log of result in fetchEndpoint if DebugMode is DETAILED - Set DebugMode to DETAILED in HardyBarthEvcsImpl if debug is true in config Reviewed-by: Michael Grill <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Johann Kaufmann <[email protected]> Co-committed-by: Johann Kaufmann <[email protected]>
Adds and changes descriptions of the modbus tables Reviewed-by: Sebastian Asen <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Fabian Brandtner <[email protected]> Co-committed-by: Fabian Brandtner <[email protected]>
- Add KEBA specific R2State-enum (for "Report 2") - KEBA: drop CHARGING_REJECTED - SessionEnergy is set to 0 on UNPLUGGED event Co-authored-by: Johann Kaufmann <[email protected]> Reviewed-by: Sebastian Asen <[email protected]> Reviewed-by: Johann Kaufmann <[email protected]>
…rclass - Implementation of ModbusRTU - Refactoring of ModbusTCP to avoid redundant classes - Implementation of ModbusRTU App - Added "Download Protocol" button for ModbusRtu Co-authored-by: Sebastian Asen <[email protected]> Co-authored-by: Stefan Feilmeier <[email protected]> Reviewed-by: Lukas Rieger <[email protected]> Reviewed-by: Michael Grill <[email protected]> Co-authored-by: Fabian Brandtner <[email protected]> Co-committed-by: Fabian Brandtner <[email protected]>
- changed na-protection text Reviewed-by: Johann Kaufmann <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Michael Grill <[email protected]> Co-committed-by: Michael Grill <[email protected]>
Co-authored-by: Pooran Chandrashekaraiah <[email protected]> Reviewed-by: Hueseyin Sahutoglu <[email protected]> Reviewed-by: Michael Grill <[email protected]>
Co-authored-by: Lukas Rieger <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Sagar Venu <[email protected]> Co-committed-by: Sagar Venu <[email protected]>
Added a "TEMPERATURE_CABINET" channel in the Battery inverter interface. Reviewed-by: Michael Grill <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Pooran Chandrashekaraiah <[email protected]> Co-committed-by: Pooran Chandrashekaraiah <[email protected]>
This fixes an issue with interrupted charging sessions due to `null` values. - added check for null values in HardyBarthReadUtils - The first 3 null values are ignored and no values are written in these cycles - Afterwards null values are written in channels as usual Reviewed-by: Sebastian Asen <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Johann Kaufmann <[email protected]> Co-committed-by: Johann Kaufmann <[email protected]>
Added endpoint to retrieve estimated installation configuration Reviewed-by: Johann Kaufmann <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Michael Grill <[email protected]> Co-committed-by: Michael Grill <[email protected]>
- fix styling of `negative-values` and `positive-values` info - restore old visibility of energy journey (only being visible for `home-10`) Reviewed-by: Sebastian Asen <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Lukas Rieger <[email protected]> Co-committed-by: Lukas Rieger <[email protected]>
- Added core app for meta component - Added Logic for updating component config via their apps Co-authored-by: Michael Grill <[email protected]> Reviewed-by: Michael Grill <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Johann Kaufmann <[email protected]> Co-committed-by: Johann Kaufmann <[email protected]>
Added check with previous state that ignores ramp for 1 cycle Reviewed-by: Sebastian Asen <[email protected]> Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Johann Kaufmann <[email protected]> Co-committed-by: Johann Kaufmann <[email protected]>
Codecov ReportAttention: Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2969 +/- ##
=============================================
- Coverage 57.08% 56.86% -0.22%
- Complexity 9732 9804 +72
=============================================
Files 2266 2281 +15
Lines 96819 97624 +805
Branches 7163 7208 +45
=============================================
+ Hits 55262 55501 +239
- Misses 39494 40038 +544
- Partials 2063 2085 +22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge
nullresponsesnullvalues.UI
negative-valuesandpositive-valuesinfo