General: Clean up Warnings in Code #2971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sn0w3y
commented
Jan 16, 2025
Sn0w3y
commented
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2971 +/- ##
==============================================
- Coverage 56.85% 26.25% -30.59%
==============================================
Files 2281 267 -2014
Lines 97624 6844 -90780
Branches 7208 1063 -6145
==============================================
- Hits 55491 1796 -53695
+ Misses 40047 4962 -35085
+ Partials 2086 86 -2000 |
|
Locally Test succeeds.. I even did not make any changes to KEBA :) 
|
sfeilmeier
added a commit
that referenced
this pull request
Jan 20, 2025
|
Closing in favour of #2976 |
sfeilmeier
added a commit
that referenced
this pull request
Jan 20, 2025
- UI
- use user language instead of browser lang for locale
- replace locale being overwritten with browserlang to be using the user lang
- fix czech locale, `cz` throwing errors for
- piping (using angular pipes)
- formatting of numbers
- replacing it with `cs` -> [Ref](https://github.com/angular/common-builds/blob/main/locales/global/cs.js)
- Improve Modbus Widget
- fixes name of channel in ModbusTCP widget (e.g. Ess1SetActivePowerEquals was shown as SetActivePowerEquals/706 in OM)
- Several ess lead to repeating register names in ModbusTcp widget.
- Dark mode pick-date improvements
- Enhancing styles of popover in accordance with dark-mode feature.
- Add handling for `Controller.IO.Heating.Room`
- Edge
- Code Cleanup for Java 21
- Migrate Switch-Case-Expressions to Switch-Case-Statements
- General code cleanup (using Eclipse "Clean up" tool)
- EVCS Mennekes: cleanup
- Cleanup Eclipse warning (#2971)
---------
Co-authored-by: Anas Shetla <[email protected]>
Co-authored-by: Lukas Rieger <[email protected]>
Co-authored-by: Fabian Brandtner <[email protected]>
Co-authored-by: Michael Grill <[email protected]>
Co-authored-by: Sebastian Asen <[email protected]>
Co-authored-by: Christian Lehne <[email protected]>
Co-authored-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Thomas Sicking <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.