Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate empty _node check removed from Subscription.hpp (#23316) #23317

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

PavloZMN
Copy link
Contributor

Solved Problem

Duplicate empty node check removal from Subscription.hpp, more details in 23316

Fixes #{23316}

Solution

Refactoring, only subscribe method is used for _node emptiness check.

Changelog Entry

For release notes:

Duplicate empty node check removal from Subscription.hpp

Test coverage

@julianoes julianoes requested a review from dagar June 28, 2024 17:20
@github-actions github-actions bot added the stale label Jul 29, 2024
@PavloZMN
Copy link
Contributor Author

Hi @sfuhrer,
Can you please take a look on this PR? More details about change specified in issue: 23316

@PavloZMN
Copy link
Contributor Author

Hi @bresch,
Can you please take a look on this PR, or include into reviewers someone who can make a review?

@PavloZMN
Copy link
Contributor Author

Hi @dagar,
Can you please take a look on change in this PR?

@PavloZMN
Copy link
Contributor Author

Hi @sfuhrer,
Can you please include in this PR reviewers someone who can take a look on changes? I don't have permission to do this.

@PavloZMN
Copy link
Contributor Author

PavloZMN commented Feb 1, 2025

Hi @davids5 ,
Can you please take a look on proposed small performance and code readability improvement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant