Yawsticks on gimbal, vehicle follows gimbal in slowmode #24242

Perrrewi · 2025-01-22T15:49:55Z

Solved Problem

The goal is to reduce latency in the position slow mode between the joystick input and what the user see. The idea is to add the yawstick on the gimbal setpoint and let the vehicle follow the gimbal attitude.

Originally after moving and releasing the joystick there was a residual motion in the image frame. With this solution, the residual motion is no longer present.

Test coverage

It has been tested in SIH with AMC (1.34.9), AOS (3.7.7) and in flight tests AMC (1.34.12) on a multicopter using different camera lenses to see that the joystick inputs changes with the focal length.

Context

Switching into position slow mode with the vehicles yaw setpoint follows the gimbal ones the device attitude status reports ROLL|PITCH|YAW LOCK. Then the feedback signal from vehicle yaw follow the new reference:

Moving the Yawstick changes the gimbals absolute yaw, and the vehicle follows:

Moving the pitch stick changes the gimbals absolute pitch using parameter to map RC_MAP_AUX4 and MC_SLOW_MAP_PTCH:

Finally switching back to position mode and the gimbal device reports flags PITCH|ROLL Lock and the vehicle remain its attitude:

github-actions · 2025-01-22T15:56:00Z

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: 1184 byte (0.06 %)]

    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.1% +1.16Ki  +0.1% +1.16Ki    .text
  [NEW]    +796  [NEW]    +796    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
   +16%    +234   +16%    +234    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  +2.1%     +60  +2.1%     +60    src/modules/flight_mode_manager/FlightTasks_generated.cpp
  +0.0%     +55  +0.0%     +55    [section .text]
  +0.5%     +20  +0.5%     +20    ../../src/modules/gimbal/input_mavlink.cpp
  +0.0%      +8  +0.0%      +8    ../../src/lib/parameters/parameters.cpp
  +0.0%      +6  +0.0%      +6    ROMFS/nsh_romfsimg.c
  +0.0%      +4  +0.0%      +4    ../../src/modules/fw_autotune_attitude_control/fw_autotune_attitude_control.cpp
  +0.1%      +4  +0.1%      +4    ../../src/modules/gyro_calibration/GyroCalibration.cpp
  +0.2%      +3  +0.2%      +3    ../../src/systemcmds/ver/ver.cpp
  -0.3%      -2  -0.3%      -2    ../../src/modules/flight_mode_manager/tasks/ManualAcceleration/FlightTaskManualAcceleration.cpp
  -0.1%      -4  -0.1%      -4    ../../src/modules/navigator/MissionFeasibility/FeasibilityChecker.cpp
+0.2% +2.99Ki  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
  +3.6%    +105  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  [NEW] +2.80Ki  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
  +1.1%     +34  [ = ]       0    ../../src/modules/gimbal/input_mavlink.cpp
+0.1%    +152  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
  +2.8%      +8  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  [NEW]    +152  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
+0.1%    +496  [ = ]       0    .debug_frame
+0.2% +68.6Ki  [ = ]       0    .debug_info
  +0.0%      +8  [ = ]       0    ../../src/drivers/batt_smbus/batt_smbus.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/cdcacm_autostart/cdcacm_autostart.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/distance_sensor/lightware_laser_i2c/lightware_laser_i2c.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/dshot/DShot.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/heater/heater.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/lights/rgbled/rgbled.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/lights/rgbled_is31fl3195/rgbled_is31fl3195.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/lights/rgbled_lp5562/rgbled_lp5562.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/lights/rgbled_ncp5623c/rgbled_ncp5623c.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/osd/msp_osd/msp_osd.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/power_monitor/ina226/ina226.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/power_monitor/ina226/ina226_main.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/power_monitor/ina228/ina228.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/power_monitor/ina228/ina228_main.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/power_monitor/ina238/ina238.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/power_monitor/ina238/ina238_main.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/power_monitor/pm_selector_auterion/PowerMonitorSelectorAuterion.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/pwm_out/PWMOut.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/px4io/px4io.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/rc/crsf_rc/CrsfRc.cpp
 -99.5% +68.4Ki  [ = ]       0    [174 Others]
+0.1% +5.95Ki  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  +0.4%     +49  [ = ]       0    ../../src/modules/flight_mode_manager/FlightModeManager.cpp
  +9.3%    +648  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  [NEW] +4.89Ki  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
  +3.1%    +283  [ = ]       0    ../../src/modules/gimbal/input_mavlink.cpp
  +1.2%    +119  [ = ]       0    src/modules/flight_mode_manager/FlightTasks_generated.cpp
  +0.5%      +6  [ = ]       0    task/task_cancelpt.c
+0.2% +10.1Ki  [ = ]       0    .debug_loc
  +0.0%     +26  [ = ]       0    ../../src/drivers/uavcan/uavcan_main.cpp
  +0.0%     +32  [ = ]       0    ../../src/drivers/uavcan/uavcan_servers.cpp
  -0.1%     -15  [ = ]       0    ../../src/lib/collision_prevention/CollisionPrevention.cpp
  +0.2%     +15  [ = ]       0    ../../src/lib/rtl/rtl_time_estimator.cpp
  -0.2%     -13  [ = ]       0    ../../src/lib/weather_vane/WeatherVane.cpp
  -0.1%     -15  [ = ]       0    ../../src/modules/airspeed_selector/airspeed_selector_main.cpp
  -0.4%     -15  [ = ]       0    ../../src/modules/commander/HealthAndArmingChecks/checks/accelerometerCheck.cpp
  -0.3%     -15  [ = ]       0    ../../src/modules/commander/ModeManagement.cpp
  -0.1%     -15  [ = ]       0    ../../src/modules/commander/failure_detector/FailureDetector.cpp
  +0.2%     +15  [ = ]       0    ../../src/modules/flight_mode_manager/FlightModeManager.cpp
  +0.0%     +15  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Auto/FlightTaskAuto.cpp
  -0.0%     -13  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/AutoFollowTarget/FlightTaskAutoFollowTarget.cpp
  +0.3%     +15  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/FlightTask/FlightTask.cpp
   +14% +1.18Ki  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  -0.0%     -13  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Orbit/FlightTaskOrbit.cpp
  +0.0%      +2  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Transition/FlightTaskTransition.cpp
  [NEW] +7.40Ki  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
  +0.2%     +15  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Sticks.cpp
  -0.1%     -64  [ = ]       0    ../../src/modules/fw_pos_control/FixedwingPositionControl.cpp
  +0.0%     +15  [ = ]       0    ../../src/modules/fw_rate_control/FixedwingRateControl.cpp
 -99.9% +1.50Ki  [ = ]       0    [12 Others]
+0.2% +2.20Ki  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
   +12%    +264  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  [NEW] +1.62Ki  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
   +11%    +312  [ = ]       0    ../../src/modules/gimbal/input_mavlink.cpp
  +0.6%     +24  [ = ]       0    src/modules/flight_mode_manager/FlightTasks_generated.cpp
+0.1% +1.82Ki  [ = ]       0    .debug_str
  +0.1%     +63  [ = ]       0    
  +0.1%     +17  [ = ]       0    ../../src/drivers/batt_smbus/batt_smbus.cpp
  -0.1%      -7  [ = ]       0    ../../src/lib/mixer_module/mixer_module.cpp
  +1.2%    +893  [ = ]       0    ../../src/modules/flight_mode_manager/FlightModeManager.cpp
   +61%    +533  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  [NEW]    +292  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
  +0.4%     +74  [ = ]       0    src/modules/flight_mode_manager/FlightTasks_generated.cpp
+0.5%      +1  [ = ]       0    .shstrtab
+0.1%    +419  [ = ]       0    .strtab
   +13%     +12  [ = ]       0    ../../src/drivers/magnetometer/st/iis2mdc/iis2mdc_main.cpp
  -8.1%     -32  [ = ]       0    ../../src/lib/version/version.c
  +7.0%     +54  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  [NEW]    +342  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
  +0.1%     +43  [ = ]       0    [section .strtab]
+0.1%    +448  [ = ]       0    .symtab
 +10.0%     +16  [ = ]       0    ../../src/drivers/magnetometer/st/iis2mdc/iis2mdc_main.cpp
  -1.2%     -16  [ = ]       0    ../../src/drivers/pwm_out/PWMOut.cpp
  -7.0%     -64  [ = ]       0    ../../src/lib/version/version.c
  +3.4%     +16  [ = ]       0    ../../src/modules/commander/lm_fit.cpp
  +4.2%     +32  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  [NEW]    +400  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
  +0.3%     +16  [ = ]       0    ../../src/modules/fw_pos_control/FixedwingPositionControl.cpp
  -0.7%     -16  [ = ]       0    ../../src/modules/mc_pos_control/MulticopterPositionControl.cpp
  +0.1%     +80  [ = ]       0    [section .symtab]
 -25.0%     -16  [ = ]       0    stdio/lib_libfflush.c
-10.2% -1.16Ki  [ = ]       0    [Unmapped]
+0.2% +93.1Ki  +0.1% +1.16Ki    TOTAL

px4_fmu-v6x [Total VM Diff: 1296 byte (0.06 %)]

    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.1% +1.20Ki  +0.1% +1.20Ki    .text
  [NEW]    +796  [NEW]    +796    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
   +16%    +234   +16%    +234    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  +2.1%     +60  +2.1%     +60    src/modules/flight_mode_manager/FlightTasks_generated.cpp
  +0.0%     +51  +0.0%     +51    [section .text]
  +0.2%     +40  +0.2%     +40    ../../src/lib/parameters/parameters.cpp
  +0.0%     +29  +0.0%     +29    ROMFS/nsh_romfsimg.c
  +0.5%     +20  +0.5%     +20    ../../src/modules/gimbal/input_mavlink.cpp
  +0.0%      +4  +0.0%      +4    ../../src/modules/fw_autotune_attitude_control/fw_autotune_attitude_control.cpp
  +0.1%      +4  +0.1%      +4    ../../src/modules/gyro_calibration/GyroCalibration.cpp
  -0.3%      -2  -0.3%      -2    ../../src/modules/flight_mode_manager/tasks/ManualAcceleration/FlightTaskManualAcceleration.cpp
  -0.1%      -4  -0.1%      -4    ../../src/modules/navigator/MissionFeasibility/FeasibilityChecker.cpp
[ = ]       0  +0.1%     +64    .bss
  [ = ]       0  +6.9%     +60    [section .bss]
  [ = ]       0  +1.4%      +8    ../../src/lib/parameters/parameters.cpp
  [ = ]       0  -0.1%      -4    ../../platforms/nuttx/src/px4/common/board_dma_alloc.c
+0.2% +2.99Ki  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
  +3.6%    +105  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  [NEW] +2.80Ki  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
  +1.1%     +34  [ = ]       0    ../../src/modules/gimbal/input_mavlink.cpp
+0.1%    +152  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
  +2.8%      +8  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  [NEW]    +152  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
+0.1%    +508  [ = ]       0    .debug_frame
+0.3% +68.0Ki  [ = ]       0    .debug_info
  +0.0%      +8  [ = ]       0    ../../src/drivers/cdcacm_autostart/cdcacm_autostart.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/distance_sensor/lightware_laser_i2c/lightware_laser_i2c.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/dshot/DShot.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/heater/heater.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/lights/rgbled/rgbled.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/lights/rgbled_is31fl3195/rgbled_is31fl3195.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/lights/rgbled_lp5562/rgbled_lp5562.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/lights/rgbled_ncp5623c/rgbled_ncp5623c.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/osd/msp_osd/msp_osd.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/power_monitor/ina226/ina226.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/power_monitor/ina226/ina226_main.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/power_monitor/ina228/ina228.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/power_monitor/ina228/ina228_main.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/power_monitor/ina238/ina238.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/power_monitor/ina238/ina238_main.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/power_monitor/pm_selector_auterion/PowerMonitorSelectorAuterion.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/pwm_out/PWMOut.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/px4io/px4io.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/rc_input/RCInput.cpp
  +0.0%      +8  [ = ]       0    ../../src/drivers/uavcan/actuators/esc.cpp
 -99.5% +67.9Ki  [ = ]       0    [163 Others]
+0.1% +5.97Ki  [ = ]       0    .debug_line
  +0.2%     +37  [ = ]       0    ../../src/lib/parameters/parameters.cpp
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  +0.4%     +49  [ = ]       0    ../../src/modules/flight_mode_manager/FlightModeManager.cpp
  +9.3%    +648  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  -0.0%      -1  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Orbit/FlightTaskOrbit.cpp
  [NEW] +4.89Ki  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
  +3.1%    +283  [ = ]       0    ../../src/modules/gimbal/input_mavlink.cpp
  +1.2%    +119  [ = ]       0    src/modules/flight_mode_manager/FlightTasks_generated.cpp
  -0.3%      -3  [ = ]       0    task/task_cancelpt.c
+0.2% +9.80Ki  [ = ]       0    .debug_loc
  +0.2%     +15  [ = ]       0    ../../src/drivers/osd/msp_osd/msp_osd.cpp
  -0.0%      -4  [ = ]       0    ../../src/drivers/uavcan/uavcan_main.cpp
  +0.0%      +4  [ = ]       0    ../../src/drivers/uavcan/uavcan_servers.cpp
  +0.1%     +15  [ = ]       0    ../../src/lib/collision_prevention/CollisionPrevention.cpp
  -0.0%      -2  [ = ]       0    ../../src/lib/parameters/parameters.cpp
  +0.1%     +15  [ = ]       0    ../../src/modules/airspeed_selector/airspeed_selector_main.cpp
  -0.1%     -15  [ = ]       0    ../../src/modules/commander/HealthAndArmingChecks/checks/estimatorCheck.cpp
  -0.2%     -15  [ = ]       0    ../../src/modules/commander/HealthAndArmingChecks/checks/magnetometerCheck.cpp
  -0.0%     -13  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/AutoFollowTarget/FlightTaskAutoFollowTarget.cpp
   +14% +1.18Ki  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  -0.7%    -186  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Orbit/FlightTaskOrbit.cpp
  [NEW] +7.40Ki  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
  +0.1%     +15  [ = ]       0    ../../src/modules/fw_att_control/FixedwingAttitudeControl.cpp
  -0.1%     -64  [ = ]       0    ../../src/modules/fw_pos_control/FixedwingPositionControl.cpp
  -0.0%     -15  [ = ]       0    ../../src/modules/fw_rate_control/FixedwingRateControl.cpp
  +8.0% +1.15Ki  [ = ]       0    ../../src/modules/gimbal/input_mavlink.cpp
  +0.0%     +15  [ = ]       0    ../../src/modules/mc_pos_control/MulticopterPositionControl.cpp
  -0.2%     -15  [ = ]       0    ../../src/modules/navigator/rtl_direct.cpp
  +0.1%     +15  [ = ]       0    ../../src/modules/sensors/sensors.cpp
  -0.1%     -29  [ = ]       0    ../../src/modules/sensors/vehicle_angular_velocity/VehicleAngularVelocity.cpp
 -100.0%    +340  [ = ]       0    [6 Others]
+0.2% +2.25Ki  [ = ]       0    .debug_ranges
  +0.4%     +56  [ = ]       0    ../../src/lib/parameters/parameters.cpp
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
   +12%    +264  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  [NEW] +1.62Ki  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
   +11%    +312  [ = ]       0    ../../src/modules/gimbal/input_mavlink.cpp
  +0.6%     +24  [ = ]       0    src/modules/flight_mode_manager/FlightTasks_generated.cpp
  +4.7%      +3  [ = ]       0    task/task_cancelpt.c
+0.1% +1.82Ki  [ = ]       0    .debug_str
  +0.1%     +63  [ = ]       0    
  +0.1%     +17  [ = ]       0    ../../src/drivers/cdcacm_autostart/cdcacm_autostart.cpp
  -0.1%      -7  [ = ]       0    ../../src/lib/mixer_module/mixer_module.cpp
  +1.2%    +882  [ = ]       0    ../../src/modules/flight_mode_manager/FlightModeManager.cpp
   +61%    +533  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  [NEW]    +292  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
  +0.1%     +12  [ = ]       0    ../../src/modules/mc_att_control/mc_att_control_main.cpp
  +0.4%     +73  [ = ]       0    src/modules/flight_mode_manager/FlightTasks_generated.cpp
+0.5%      +1  [ = ]       0    .shstrtab
+0.1%    +419  [ = ]       0    .strtab
   +13%     +12  [ = ]       0    ../../src/drivers/magnetometer/st/iis2mdc/iis2mdc_main.cpp
  -8.1%     -32  [ = ]       0    ../../src/lib/version/version.c
  +7.0%     +54  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  [NEW]    +342  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
  +0.8%     +13  [ = ]       0    ../../src/modules/land_detector/LandDetector.cpp
  +0.1%     +43  [ = ]       0    [section .strtab]
  -1.4%     -13  [ = ]       0    src/modules/flight_mode_manager/FlightTasks_generated.cpp
+0.1%    +448  [ = ]       0    .symtab
 +10.0%     +16  [ = ]       0    ../../src/drivers/magnetometer/st/iis2mdc/iis2mdc_main.cpp
  -1.2%     -16  [ = ]       0    ../../src/drivers/pwm_out/PWMOut.cpp
  +2.1%     +16  [ = ]       0    ../../src/lib/sensor_calibration/Magnetometer.cpp
  -7.0%     -64  [ = ]       0    ../../src/lib/version/version.c
  +4.0%     +32  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp
  +2.1%     +16  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Orbit/FlightTaskOrbit.cpp
  [NEW]    +400  [ = ]       0    ../../src/modules/flight_mode_manager/tasks/Utility/Gimbal.cpp
  +0.3%     +16  [ = ]       0    ../../src/modules/fw_pos_control/FixedwingPositionControl.cpp
  +1.5%     +16  [ = ]       0    ../../src/modules/land_detector/LandDetector.cpp
  +1.1%     +16  [ = ]       0    ../../src/modules/mc_rate_control/MulticopterRateControl.cpp
  +0.0%     +16  [ = ]       0    [section .symtab]
 -25.0%     -16  [ = ]       0    stdio/lib_libfflush.c
-1.7% -1.20Ki  [ = ]       0    [Unmapped]
+0.2% +92.4Ki  +0.1% +1.27Ki    TOTAL

Updated: 2025-01-31T09:15:13

sfuhrer

I just have a couple of high-level comments so far:

there is a failed CI check (clang tidy)
v6x is out of flash - we may need to free up some flash before bringing this in

...ules/flight_mode_manager/tasks/ManualAccelerationSlow/flight_task_acceleration_slow_params.c

src/modules/logger/logged_topics.cpp

...odules/flight_mode_manager/tasks/ManualAccelerationSlow/FlightTaskManualAccelerationSlow.cpp

msg/GimbalManagerSetAttitude.msg

Perrrewi · 2025-01-22T17:37:36Z

I just have a couple of high-level comments so far:

there is a failed CI check (clang tidy)

v6x is out of flash - we may need to free up some flash before bringing this in

Thanks for the review @sfuhrer , I updated the PR accordingly. I'll talk in person about freeing up some flash.

…cations with queue length 1

FlightTaskManualAccelerationSlow: avoid misalignment of gimbal and vehicle before takeoff

…itch and yaw

…ick shaping

Perrrewi assigned MaEtUgR and Perrrewi Jan 22, 2025

MaEtUgR mentioned this pull request Jan 22, 2025

Gimbal v2 protocol: mix yaw from vehicle and pitch from ground station mavlink/mavlink#2202

Open

dagar marked this pull request as draft January 22, 2025 16:27

sfuhrer reviewed Jan 22, 2025

View reviewed changes

Perrrewi force-pushed the pernilla/vehicle-follow-gimbal-in-slow-mode branch from a9ab69a to 929d713 Compare January 22, 2025 17:23

Perrrewi and others added 6 commits January 30, 2025 09:56

Yawsticks on gimbal, vehicle follows gimbal in slowmode

c1f3fea

Increase queue length to avoid automatically unadvertise queued publi…

cd6a993

…cations with queue length 1

small review fixes: changing to references, and adding const

87c4ce4

Gimbal: getting pitch input from gimbal_manager_set_manual_control

d58a5f6

FlightTaskManualAccelerationSlow: avoid misalignment of gimbal and vehicle before takeoff

FlightTaskManualAccelerationSlow: separate stick sahping for gimbal p…

a471eb0

…itch and yaw

Minimalizing, by removing knob specific pitch rate, and remove the st…

f8cd789

…ick shaping

Perrrewi force-pushed the pernilla/vehicle-follow-gimbal-in-slow-mode branch from dd6a228 to f8cd789 Compare January 31, 2025 09:09

Perrrewi changed the title ~~DRAFT: Yawsticks on gimbal, vehicle follows gimbal in slowmode~~ Yawsticks on gimbal, vehicle follows gimbal in slowmode Jan 31, 2025

Perrrewi marked this pull request as ready for review January 31, 2025 10:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Yawsticks on gimbal, vehicle follows gimbal in slowmode #24242

Yawsticks on gimbal, vehicle follows gimbal in slowmode #24242

Perrrewi commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading

sfuhrer left a comment

Perrrewi commented Jan 22, 2025 •

edited

Loading

Yawsticks on gimbal, vehicle follows gimbal in slowmode #24242

Are you sure you want to change the base?

Yawsticks on gimbal, vehicle follows gimbal in slowmode #24242

Conversation

Perrrewi commented Jan 22, 2025 • edited Loading

Solved Problem

Test coverage

Context

github-actions bot commented Jan 22, 2025 • edited Loading

🔎 FLASH Analysis

sfuhrer left a comment

Choose a reason for hiding this comment

Perrrewi commented Jan 22, 2025 • edited Loading

Perrrewi commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading

Perrrewi commented Jan 22, 2025 •

edited

Loading