Import proto (without java_package) from another package #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctory is located in target.
…kage should default to proto package if undefined according to spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.4.0, importing from another package doesn't work anymore if java_package is undefined in the imported file.
java_package should default to proto package according to spec.
I have also done some fixes in the test code (filename case and line endings) so it will succeed in Linux as well.
Some testcases wrote their output to src/test/resources and wrote over the example files. When they later compared the generated files with the example files, it was the same files and it would always succeed. I moved output dir to target to solve that.