Add more tests

Setono · Mar 3, 2025 · c5142b6 · c5142b6
1 parent d07046c
commit c5142b6
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 2 deletions.
diff --git a/src/CronBuilder.php b/src/CronBuilder.php
@@ -140,7 +140,7 @@ public static function merge(string $existingCron, self $cronBuilder): string
         );
 
         if (0 === $replacements) {
-            return $existingCron . "\n" . $cron;
+            return $existingCron . "\n\n" . $cron;
         }
 
         if (1 === $replacements) {

diff --git a/tests/CronBuilderTest.php b/tests/CronBuilderTest.php
@@ -46,7 +46,7 @@ public function it_builds_with_prod_env_set(): void
     /**
      * @test
      */
-    public function it_merges(): void
+    public function it_merges1(): void
     {
         $existingCrontab = <<<CRON
 
@@ -60,6 +60,44 @@ public function it_merges(): void
 
 
 
+CRON;
+
+        $expected = <<<CRON
+0 0 * * * /usr/bin/php /home/johndoe/public_html/other-job.php
+
+###> Generated by PHPUnit ###
+0 0 * * * /usr/bin/php /home/johndoe/public_html/12/send-report.php --verbose # Run every day at midnight
+###< Generated by PHPUnit ###
+
+CRON;
+
+        self::assertSame($expected, CronBuilder::merge($existingCrontab, self::getCronBuilder()));
+    }
+
+    /**
+     * @test
+     */
+    public function it_merges2(): void
+    {
+        $existingCrontab = '';
+
+        $expected = <<<CRON
+###> Generated by PHPUnit ###
+0 0 * * * /usr/bin/php /home/johndoe/public_html/12/send-report.php --verbose # Run every day at midnight
+###< Generated by PHPUnit ###
+
+CRON;
+
+        self::assertSame($expected, CronBuilder::merge($existingCrontab, self::getCronBuilder()));
+    }
+
+    /**
+     * @test
+     */
+    public function it_merges3(): void
+    {
+        $existingCrontab = <<<CRON
+0 0 * * * /usr/bin/php /home/johndoe/public_html/other-job.php
 CRON;
 
         $expected = <<<CRON