Add type definitions #94

FDiskas · 2017-11-10T14:43:33Z

Closes #91

Sharlaan · 2017-11-13T21:11:59Z

Can you update or remake this PR or rebase, this time based on new master branch please ?

…rselectfield into feature/typedefinitions # Conflicts: # package-lock.json # package.json

FDiskas · 2017-11-13T21:57:33Z

lib/SuperSelectField.d.ts

+    import {Component} from 'react';
+
+    export interface SelectFieldProps {
+        anchorOrigin?: any;


Why everywhere types are any?
KnisterPeter/react-to-typescript-definitions#439

and this file should be in ignore to :)

Speaking to yourself ? ^^

Just info :)

codecov-io · 2017-11-13T21:58:38Z

Codecov Report

Merging #94 into master will decrease coverage by 1.1%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   42.07%   40.97%   -1.11%     
==========================================
  Files           6        6              
  Lines         202      205       +3     
==========================================
- Hits           85       84       -1     
- Misses        117      121       +4

Impacted Files	Coverage Δ
src/defaultProps.js	`53.84% <0%> (-4.49%)`	⬇️
src/utils.js	`36% <0%> (-3.14%)`	⬇️
src/SuperSelectField.js	`38.84% <0%> (-0.33%)`	⬇️
src/FloatingLabel.js	`22.22% <0%> (ø)`	⬆️
src/SelectionsPresenter.js	`100% <0%> (ø)`	⬆️
src/types/index.js	`33.33% <0%> (+2.56%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a72665...04b90b7. Read the comment docs.

FDiskas · 2017-11-13T22:04:51Z

Useless codecov comment. Anybody knows how to turn off commenting on pull requests?

Sharlaan · 2017-11-13T22:12:29Z

One question:
Have you tried installing and using both the es5 and module versions of material-ui-superselectifled, on a dummy page featuring react/react-dom/material-ui ?

I'm asking this following your modification of package.json properties "main" and "module".

FDiskas · 2017-11-13T22:55:23Z

I tried to npm run build and that index.js was missing 🐩
Logic is simple.

User installs material-ui-superselectfield
Users imports import * as Select from 'material-ui-superselectfield'
Webpack (or whatever is) will look in node_modules the directory material-ui-superselectfield
Opens modules package.json file and looks for "main" section, because user was not specified the file in import statment

Sharlaan · 2017-11-13T23:03:48Z

If you read NWB documentation as suggested few days ago, you would have learn that :
lib/ contains the es5 version, transpiled
es/ contains the module-compatible version, by extension untranspiled since module import is last EcmaScript feature implemented into nowadays browsers
so this means :

you MUST include these folders in npm publish
index.js allows the browser JS engine to get all needed files (reminder they are splitted !) by default
So if you rename this file browser won't import properly

There is a third build, it were the original form of my project before this transfer to NWB: the UMD.
In this particular build case, yea all component files are concatenated into one.
We didnot include this one, es5 and module versions should be enough for most projects.

FDiskas · 2017-11-13T23:21:23Z

You should check the results after pre released
https://unpkg.com/material-ui-superselectfield/ and check the "main" section in package.json

Sharlaan · 2017-11-13T23:27:13Z

What your link is pointing at, is a "UMD" build.
As explained above, we decided to ditch this in favor of es5 and es6+ module versions...

FDiskas · 2017-11-13T23:31:01Z

Yes link is pointing to the latest npm module version. Try publishing the new version of current refactored environment. You will see some changes. And the "main" section of package.json will be wrong.
And yes - got the point what you talking about. But keep in mind that by using UMD is a good way to test for users your component for example in jsbin.com

…rselectfield into feature/typedefinitions # Conflicts: # package.json

FDiskas · 2017-11-15T12:08:26Z

@Sharlaan any news about this?

Sharlaan

This PR is about type definition, not storybook. You shouldnot mix.

Storybook (and htis addon) are already scheduled, so useless to add this here or any PR.

Sharlaan · 2017-11-15T12:09:06Z

package.json

@@ -70,6 +70,7 @@
    "react-dom": "^16.1.0",
    "react-router": "^4.2.0",
    "react-router-dom": "^4.2.2",
-    "react-to-typescript-definitions": "^0.22.0"
+    "react-to-typescript-definitions": "^0.22.0",
+    "storybook-addon-material-ui": "^0.8.2"


This PR is about type definition, not storybook. You shouldnot mix.

Storybook (and htis addon) are already scheduled, so useless to add this here or any PR.

I just merged the master branch

You should check https://github.com/Sharlaan/material-ui-superselectfield/pull/94/files

Ah ok, probably Max started on storybook.

…rselectfield into feature/typedefinitions # Conflicts: # package.json

…rselectfield into feature/typedefinitions # Conflicts: # package-lock.json

FDiskas · 2017-11-20T08:15:26Z

DO something. Can't wait and fix merge conflicts to often

KnisterPeter · 2017-11-22T07:37:22Z

Added support for prop-types: KnisterPeter/react-to-typescript-definitions#439 (comment)

FDiskas · 2017-11-22T12:34:33Z

cool 👖

FDiskas · 2017-12-08T15:18:55Z

Conflicting files
package-lock.json

so why I'm not using npm any more. Use yarn instead :)

…rselectfield into feature/typedefinitions # Conflicts: # package-lock.json # package.json

…ature/typedefinitions # Conflicts: # package-lock.json

FDiskas · 2017-12-20T15:44:44Z

Note definitions should not be committed. They must be generated on each build.

I'm right?

FDiskas added 2 commits November 10, 2017 16:42

Add type definitions

523d03c

wrong place.

37dcb3e

FDiskas mentioned this pull request Nov 10, 2017

TypeScript support #91

Open

FDiskas added 2 commits November 13, 2017 23:54

Merge branch 'master' of https://github.com/Sharlaan/material-ui-supe…

6817af5

…rselectfield into feature/typedefinitions # Conflicts: # package-lock.json # package.json

Merge branch 'master' of https://github.com/Sharlaan/material-ui-supe…

39bf6a8

…rselectfield into feature/typedefinitions # Conflicts: # package-lock.json # package.json

FDiskas commented Nov 13, 2017

View reviewed changes

Ignore this file. It will be generated on build time

2610ef9

Revert main and module

fc50dd6

Merge branch 'master' of https://github.com/Sharlaan/material-ui-supe…

fb0e3e0

…rselectfield into feature/typedefinitions # Conflicts: # package.json

Sharlaan requested changes Nov 15, 2017

View reviewed changes

FDiskas added 3 commits November 15, 2017 16:26

Merge branch 'master' of https://github.com/Sharlaan/material-ui-supe…

67c56a4

…rselectfield into feature/typedefinitions # Conflicts: # package.json

Merge branch 'master' of https://github.com/Sharlaan/material-ui-supe…

c3fde4f

…rselectfield into feature/typedefinitions # Conflicts: # package-lock.json

Merge branch 'master' of https://github.com/Sharlaan/material-ui-supe…

66a7a96

…rselectfield into feature/typedefinitions # Conflicts: # package-lock.json

FDiskas and others added 3 commits December 8, 2017 17:30

Add type definitions

998a63e

Merge branch 'master' of https://github.com/Sharlaan/material-ui-supe…

169b749

…rselectfield into feature/typedefinitions # Conflicts: # package-lock.json # package.json

Ignore this file. It will be generated on build time

1e14439

FDiskas added 2 commits December 8, 2017 17:31

Merge remote-tracking branch 'origin/feature/typedefinitions' into fe…

64cf3b2

…ature/typedefinitions # Conflicts: # package-lock.json

Merge

04b90b7

FDiskas closed this Feb 27, 2018

FDiskas deleted the feature/typedefinitions branch February 27, 2018 12:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add type definitions #94

Add type definitions #94

FDiskas commented Nov 10, 2017

Sharlaan commented Nov 13, 2017

FDiskas Nov 13, 2017

FDiskas Nov 13, 2017

Sharlaan Nov 13, 2017

FDiskas Dec 20, 2017

codecov-io commented Nov 13, 2017 •

edited

Loading

FDiskas commented Nov 13, 2017

Sharlaan commented Nov 13, 2017

FDiskas commented Nov 13, 2017 •

edited

Loading

Sharlaan commented Nov 13, 2017

FDiskas commented Nov 13, 2017 •

edited

Loading

Sharlaan commented Nov 13, 2017

FDiskas commented Nov 13, 2017 •

edited

Loading

FDiskas commented Nov 15, 2017

Sharlaan left a comment

Sharlaan Nov 15, 2017

FDiskas Nov 15, 2017

FDiskas Nov 15, 2017

Sharlaan Nov 15, 2017

FDiskas commented Nov 20, 2017

KnisterPeter commented Nov 22, 2017

FDiskas commented Nov 22, 2017

FDiskas commented Dec 8, 2017

FDiskas commented Dec 20, 2017 •

edited

Loading

Add type definitions #94

Add type definitions #94

Conversation

FDiskas commented Nov 10, 2017

Sharlaan commented Nov 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Nov 13, 2017 • edited Loading

Codecov Report

FDiskas commented Nov 13, 2017

Sharlaan commented Nov 13, 2017

FDiskas commented Nov 13, 2017 • edited Loading

Sharlaan commented Nov 13, 2017

FDiskas commented Nov 13, 2017 • edited Loading

Sharlaan commented Nov 13, 2017

FDiskas commented Nov 13, 2017 • edited Loading

FDiskas commented Nov 15, 2017

Sharlaan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FDiskas commented Nov 20, 2017

KnisterPeter commented Nov 22, 2017

FDiskas commented Nov 22, 2017

FDiskas commented Dec 8, 2017

FDiskas commented Dec 20, 2017 • edited Loading

codecov-io commented Nov 13, 2017 •

edited

Loading

FDiskas commented Nov 13, 2017 •

edited

Loading

FDiskas commented Nov 13, 2017 •

edited

Loading

FDiskas commented Nov 13, 2017 •

edited

Loading

FDiskas commented Dec 20, 2017 •

edited

Loading