Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type definitions #94

Closed
wants to merge 15 commits into from
Closed

Add type definitions #94

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
523d03c
Add type definitions
FDiskas Nov 10, 2017
37dcb3e
wrong place.
FDiskas Nov 10, 2017
6817af5
Merge branch 'master' of https://github.com/Sharlaan/material-ui-supe…
FDiskas Nov 13, 2017
39bf6a8
Merge branch 'master' of https://github.com/Sharlaan/material-ui-supe…
FDiskas Nov 13, 2017
2610ef9
Ignore this file. It will be generated on build time
FDiskas Nov 13, 2017
fc50dd6
Revert main and module
FDiskas Nov 13, 2017
fb0e3e0
Merge branch 'master' of https://github.com/Sharlaan/material-ui-supe…
FDiskas Nov 15, 2017
67c56a4
Merge branch 'master' of https://github.com/Sharlaan/material-ui-supe…
FDiskas Nov 15, 2017
c3fde4f
Merge branch 'master' of https://github.com/Sharlaan/material-ui-supe…
FDiskas Nov 20, 2017
66a7a96
Merge branch 'master' of https://github.com/Sharlaan/material-ui-supe…
FDiskas Nov 20, 2017
998a63e
Add type definitions
FDiskas Nov 10, 2017
169b749
Merge branch 'master' of https://github.com/Sharlaan/material-ui-supe…
FDiskas Nov 13, 2017
1e14439
Ignore this file. It will be generated on build time
FDiskas Nov 13, 2017
64cf3b2
Merge remote-tracking branch 'origin/feature/typedefinitions' into fe…
FDiskas Dec 8, 2017
04b90b7
Merge
FDiskas Dec 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
"react-dom": "^16.1.0",
"react-router": "^4.2.0",
"react-router-dom": "^4.2.2",
"react-to-typescript-definitions": "^0.22.0"
"react-to-typescript-definitions": "^0.22.0",
"storybook-addon-material-ui": "^0.8.2"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is about type definition, not storybook. You shouldnot mix.

Storybook (and htis addon) are already scheduled, so useless to add this here or any PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged the master branch

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should check https://github.com/Sharlaan/material-ui-superselectfield/pull/94/files

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, probably Max started on storybook.

}
}
You are viewing a condensed version of this merge commit. You can view the full changes here.