-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BMI323 and BMM350 implementation #296
Conversation
- Added temperature calibration (untested yet) - Set performance mode of gyro and accel to high
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright, I can't really review the IMU specific code but it looks alright from a skim over.
Fix CalibrationConfigType order to prevent existing configs from breaking
Looking to merge this soon, if anyone would like to review this or give feedback before it is merged, now is the time! |
Hi, are the changes correct please? |
- Ran VSCode formatter on BMI323 files - Changed const to define to save ram - Changed serial to logger
As discussions in discord,.. show that the BMI323 works bad and only about 5 ppl have sets, i'm not sure if it is a good idea to integrate this into main. Want to hear other opinions on it. |
Replying a bit late sorry, while the BMI323 isn't the best sensor out there, it's about the same as the BMI160 in term of tracking quality. I've been using my code regularly for the past few months and never had any crash or issue. I'd say the main issue is when you're moving, if I'm moving around my reset time is probably a bad 5 - 10 minutes |
Closed because I implemented sfusion, will reopen a new PR |
It went ~100 hours of testing with no major issues so far, maybe some adjustments will be needed especially on the calibration side