Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMI323 and BMM350 implementation #296

Closed
wants to merge 17 commits into from
Closed

BMI323 and BMM350 implementation #296

wants to merge 17 commits into from

Conversation

jojos38
Copy link
Contributor

@jojos38 jojos38 commented Oct 2, 2023

  • Working BMI323 at 400hz gyro and 200hz accel
  • Working BMM350 with sensor fusion

It went ~100 hours of testing with no major issues so far, maybe some adjustments will be needed especially on the calibration side

- Working BMI323 at 400hz gyro and 200hz accel
- Working BMM350 with sensor fusion
- Added temperature calibration (untested yet)
- Set performance mode of gyro and accel to high
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright, I can't really review the IMU specific code but it looks alright from a skim over.

src/configuration/CalibrationConfig.h Outdated Show resolved Hide resolved
src/sensors/bmi323sensor.cpp Outdated Show resolved Hide resolved
src/sensors/bmi323sensor.h Outdated Show resolved Hide resolved
@ButterscotchV
Copy link
Member

Looking to merge this soon, if anyone would like to review this or give feedback before it is merged, now is the time!

lib/bmi323/bmi323_jojos38.cpp Outdated Show resolved Hide resolved
lib/bmi323/bmi323_jojos38.cpp Outdated Show resolved Hide resolved
@jojos38
Copy link
Contributor Author

jojos38 commented Mar 13, 2024

Hi, are the changes correct please?

src/sensors/bmi323sensor.cpp Show resolved Hide resolved
src/sensors/bmi323sensor.h Show resolved Hide resolved
src/sensors/bmi323sensor.h Outdated Show resolved Hide resolved
jojos38 added 2 commits April 10, 2024 21:29
- Ran VSCode formatter on BMI323 files
- Changed const to define to save ram
- Changed serial to logger
@unlogisch04
Copy link
Contributor

As discussions in discord,.. show that the BMI323 works bad and only about 5 ppl have sets, i'm not sure if it is a good idea to integrate this into main. Want to hear other opinions on it.

@jojos38
Copy link
Contributor Author

jojos38 commented Sep 4, 2024

As discussions in discord,.. show that the BMI323 works bad and only about 5 ppl have sets, i'm not sure if it is a good idea to integrate this into main. Want to hear other opinions on it.

Replying a bit late sorry, while the BMI323 isn't the best sensor out there, it's about the same as the BMI160 in term of tracking quality. I've been using my code regularly for the past few months and never had any crash or issue.

I'd say the main issue is when you're moving, if I'm moving around my reset time is probably a bad 5 - 10 minutes
However, if I'm sitting it's closer to 30 minutes and if I almost don't move it can be a few hours

@jojos38 jojos38 closed this Sep 19, 2024
@jojos38
Copy link
Contributor Author

jojos38 commented Sep 19, 2024

Closed because I implemented sfusion, will reopen a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants