Skip to content

feat: Introduce zuul job for building docs #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Introduce zuul job for building docs #312

wants to merge 2 commits into from

Conversation

gtema
Copy link
Contributor

@gtema gtema commented Apr 30, 2025

No description provided.

@gtema
Copy link
Contributor Author

gtema commented Apr 30, 2025

recheck

@gtema
Copy link
Contributor Author

gtema commented Apr 30, 2025

recheck

@gtema
Copy link
Contributor Author

gtema commented Apr 30, 2025

recheck

@gtema gtema force-pushed the zuul branch 2 times, most recently from 417725d to b530f7f Compare April 30, 2025 11:13
@gtema gtema marked this pull request as draft May 2, 2025 08:38
@gtema
Copy link
Contributor Author

gtema commented May 5, 2025

@garloff Now the build looks okay with a workaround proposed in facebook/docusaurus#448 (comment) Replacing the baseURL with the Zuul url is not trivial, since the URL at which document will be published may not be known until the moment of upload.
Other problem I have noticed during this work is #314 where all documents pulled from somewhere else introduce broken links which cannot be caught. The "edit this page" functionality is best to be disabled as such due to that, but there might be another broken links.

@garloff
Copy link
Member

garloff commented Jun 19, 2025

Ah, nice, thanks @gtema .
So we should be able to have local builds with working links and also have validation in zuul, right?

You have marked this as Draft -- wanna mark it as ready for review?

@garloff garloff requested review from garloff and maxwolfs June 19, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants