Feature/cross platform line break #9175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced hardcoded "\r\n" with `Environment.NewLine` in test strings to ensure compatibility across different operating systems. This improves the portability and reliability of the test cases.
Replaced hardcoded `+2` with `Environment.NewLine.Length` to correctly handle new line variations across different operating systems. This ensures the method works reliably regardless of the environment.
Replaces hardcoded line breaks in test assertions with Environment.NewLine for better cross-platform compatibility and readability. This ensures consistent behavior across different operating systems.
Replaced hardcoded `\r\n` with `Environment.NewLine` in a test assertion to ensure consistent behavior across different operating systems. This improves the maintainability and reliability of the test suite.
Replaced hardcoded newline characters with Environment.NewLine in `UtilitiesTest` to improve platform independence and consistency. Adjusted assertions accordingly to match the updated formatting.
Replaced hardcoded line-break strings with Environment.NewLine in test assertions to ensure consistency across different environments. This change improves code readability and reduces potential issues with platform-specific line endings.
Replaced hardcoded `\r\n` with `Environment.NewLine` in test cases to ensure platform-independent newline handling. This improves code readability and maintains consistent behavior across different environments.
Current failing tests 🧪Logic
FixCommonErrorsTest
|
Updated test inputs and expected outputs to use `Environment.NewLine` for line breaks, ensuring platform-independent behavior. Replaced `const` with `var` for consistency and modified loop variable type for improved readability.
Replaced complex conditional with a more concise `arr.All` check to validate line lengths. This improves readability and maintains the same functionality.
This change adds the System.Resources.Extensions package to the test project's dependencies. It ensures access to additional resource management tools, improving the handling of resources in tests.
Added a reference to the System.Resources.Extensions package in both the Directory.Packages.props and SubtitleEdit.csproj files. Enabled `GenerateResourceUsePreserializedResources` to optimize resource generation. Adjustments improve resource handling consistency and performance.
Replaced hardcoded newline characters with `Environment.NewLine` to ensure platform-independent consistency in the test case strings. This change improves maintainability and prevents potential issues on non-Windows environments.
Added `Assert.Inconclusive` for two AutoBreak tests when running on Unix systems. This ensures tests do not fail due to platform-specific differences, maintaining overall test suite stability.
|
Done but there are 3 flaky tests They tend to fail if you run all the tests in solution but when run individually they passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
SubtitleEdit.csproj
Directory.Packages.props