-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash Rfq privateData #222
Hash Rfq privateData #222
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
+ Coverage 79.39% 84.34% +4.95%
==========================================
Files 35 38 +3
Lines 820 1124 +304
Branches 75 114 +39
==========================================
+ Hits 651 948 +297
+ Misses 133 124 -9
- Partials 36 52 +16
|
8addb50
to
e284afc
Compare
428c714
to
00482eb
Compare
9f92124
to
c49bb82
Compare
c49bb82
to
247dc62
Compare
247dc62
to
d23eada
Compare
…ing the tbdex submodule
…to rfq-private-salt
protocol/src/main/kotlin/tbdex/sdk/protocol/models/MessageData.kt
Outdated
Show resolved
Hide resolved
* main: Create message-kind-specific parse methods and remove circular dependency (#224)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Offline, @mistermoe @jiyoontbd @KendallWeihe @kirahsapong and I discussed a DX improvement:
Rename classes with the Unhashed*
prefix to instead of Create*
prefix, e.g. UnhashedRfqData
-> CreateRfqData
and UnhashedPayinMethod
-> CreatePayinMethod
.
We came to this decision because we believe that introducing the concept of hashing when sdk consumer is trying to Rfq.create()
causes confusion, and hashing should be an implementation detail. If they choose, the developer can learn more about hashing through either the ktdocs of the relevant types like RfqData
or RfqPrivateData
, or the tbdex protocol spec, which outlines the structure of the Rfq returned from calling create()
I'll push a commit for this in juuuust a sec.
b19ac60
to
0701c30
Compare
0701c30
to
5d46ac0
Compare
Co-authored-by: Jiyoon Koo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple nits for doc, not blocking. well done 🎉
Co-authored-by: Jiyoon Koo <[email protected]>
Implement min bar changes laid out in this spec change: TBD54566975/tbdex#294
In further PRs, we could improve ergonomics around validating/disclosing specific
privateData
fields.See also equivalent PR in tbdex-js: TBD54566975/tbdex-js#215