Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12663] Instructor's Student Records Page: Tooltips for comments #12676

Merged
merged 6 commits into from
Dec 28, 2023

Conversation

yuanxi1
Copy link
Contributor

@yuanxi1 yuanxi1 commented Dec 22, 2023

Fixes #12663

Outline of Solution
The tooltip for comment/edit time causes the rest of the text to go into the next line is because comment/edit time's parent element is a <span>. The tooltip window element created when hovering over the comment/edit time will be a a child element of this <span>. Changing it to a block element <ng-container> fixes the issue.

Alternative:
An alternative is to set container="body" so that the tooltip will be attached as a last child of the element (doc) this makes sure that the tooltip window is outside of the <span> element.

Screenshots:
Screenshot 2023-12-22 at 10 06 16 PM
Screenshot 2023-12-22 at 10 06 24 PM

@yuanxi1 yuanxi1 marked this pull request as draft December 22, 2023 14:41
@yuanxi1 yuanxi1 marked this pull request as ready for review December 22, 2023 15:51
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@weiquu weiquu added the s.FinalReview The PR is ready for final review label Dec 23, 2023
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. LGTM, thank you for your contribution!

@domlimm domlimm merged commit 5de8300 into TEAMMATES:master Dec 28, 2023
9 checks passed
@wkurniawan07 wkurniawan07 added c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Jan 21, 2024
@wkurniawan07 wkurniawan07 modified the milestones: V8.29.0, V8.30.0 Jan 21, 2024
cedricongjh pushed a commit to cedricongjh/teammates that referenced this pull request Feb 20, 2024
…ments (TEAMMATES#12676)

* Fix comment tooltip causing the text to go into next line

* Update snapshot test

---------

Co-authored-by: YX Z <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
Co-authored-by: Dominic Lim <[email protected]>
Co-authored-by: Jason Qiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructor's Student Records Page: Tooltips for comments
5 participants