Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract connectionBufferSize DcpBufferSize to interface for support kb,mb size units #71

Closed
wants to merge 5 commits into from

Conversation

Abdulsametileri
Copy link
Member

with this pr, users can easily specify connectionBufferSize, dcp.bufferSize value as kb mb values or use raw bytes

for example,

metadata:
  config:
    bucket: cbes-checkpoint-ProductCenter
    connectionBufferSize: 5mb // support size unit

dcp:
  connectionTimeout: 10s
  connectionBufferSize: 15mb // support size unit
  bufferSize: 20mb // support size unit
  listener:
    bufferSize: 1000 <-- this is internal channel buffer size, its not reasonable to support
  group:
    name: it_will_be_overriden
    membership:
      type: couchbase

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config/dcp.go Outdated Show resolved Hide resolved
@Abdulsametileri Abdulsametileri deleted the feature/int-related-configs branch November 11, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants