Update retry-policies to 0.5 #233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musicinmybrain
force-pushed
the
retry-policies-0.5
branch
from
f5da2ac to
3f65b58
Compare
jayvdb
approved these changes
May 17, 2025
|
Would be a good idea to update the |
jayvdb
approved these changes
May 17, 2025
|
Heads up, there's a new version of retry-policies @musicinmybrain you could grab for this |
I think |
|
Could this be merged and released? This is currently blocking us to update some other dependencies as well. |
The build_with_total_retry_duration_and_max_retries method of retry_policies::policies::ExponentialBackoffBuilder was renamed to build_with_total_retry_duration_and_limit_retries. No code changes are required, but since reqwest-retry re-exports retry-policies::policies as reqwest_retry::policies, this is a SemVer-breaking change for reqwest-retry as well.
musicinmybrain
force-pushed
the
retry-policies-0.5
branch
from
27e379a to
26d50a7
Compare
|
(Rebased without changes.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
build_with_total_retry_duration_and_max_retries methodofretry_policies::policies::ExponentialBackoffBuilderwas renamed tobuild_with_total_retry_duration_and_limit_retries. No code changes are required, but sincereqwest-retryre-exportsretry-policies::policiesasreqwest_retry::policies, this is a SemVer-breaking change forreqwest-retryas well.