-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration of integration tests to pytest #1274
base: main
Are you sure you want to change the base?
Conversation
… in conftest and test_common
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
========================================
+ Coverage 3.59% 6.25% +2.65%
========================================
Files 13 28 +15
Lines 947 2784 +1837
Branches 152 355 +203
========================================
+ Hits 34 174 +140
- Misses 843 2608 +1765
+ Partials 70 2 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@URJala is this ready to review? |
Yes, we talked about it maybe not being ideal to re-launch the driver between each test case, which is the only way I was able to make it work. You said you would take a look, and see if you could find anything that would keep the driver between test-cases. Otherwise feedback on the structure of the conftest and robot driver package is also welcome |
How would I supposed to be running that? I am not that familiar with pytest / launch_pytest so I might just be stupid, but the standard Edit: ament_add_pytest_test(robot_driver_test test/robot_driver.py
TIMEOUT
800
) However, for me the test is stuck on |
I run it with |
The tests in robot_driver.py run, and initialisation is done entirely in conftest and test_common